cleanup: regenerate older scaffolds (#8070)

Regenerate the scaffold for several older libraries, I am mainly
interested in using globs for the BUILD.bazel files.

Author: coryan

google/cloud/accessapproval/BUILD.bazel

@@ -16,12 +16,24 @@ package(default_visibility = ["//visibility:private"])
 
 licenses(["notice"])  # Apache 2.0
 
-load(":google_cloud_cpp_accessapproval.bzl", "google_cloud_cpp_accessapproval_hdrs", "google_cloud_cpp_accessapproval_srcs")
+SOURCE_GLOB = "**/*.cc"
+
+MOCK_SOURCE_GLOB = "mocks/*.cc"
+
+HEADER_GLOB = "**/*.h"
+
+MOCK_HEADER_GLOB = "mocks/*.h"
 
 cc_library(
     name = "google_cloud_cpp_accessapproval",
-    srcs = google_cloud_cpp_accessapproval_srcs,
-    hdrs = google_cloud_cpp_accessapproval_hdrs,
+    srcs = glob(
+        include = [SOURCE_GLOB],
+        exclude = [MOCK_SOURCE_GLOB],
+    ),
+    hdrs = glob(
+        include = [HEADER_GLOB],
+        exclude = [MOCK_HEADER_GLOB],
+    ),
     visibility = ["//:__pkg__"],
     deps = [
         "//google/cloud:google_cloud_cpp_common",
@@ -30,12 +42,14 @@ cc_library(
     ],
 )
 
-load(":google_cloud_cpp_accessapproval_mocks.bzl", "google_cloud_cpp_accessapproval_mocks_hdrs", "google_cloud_cpp_accessapproval_mocks_srcs")
-
 cc_library(
     name = "google_cloud_cpp_accessapproval_mocks",
-    srcs = google_cloud_cpp_accessapproval_mocks_srcs,
-    hdrs = google_cloud_cpp_accessapproval_mocks_hdrs,
+    srcs = glob(
+        include = [MOCK_SOURCE_GLOB],
+    ),
+    hdrs = glob(
+        include = [MOCK_HEADER_GLOB],
+    ),
     visibility = ["//:__pkg__"],
     deps = [
         ":google_cloud_cpp_accessapproval",

google/cloud/accessapproval/CMakeLists.txt

@@ -82,11 +82,6 @@ target_compile_options(google_cloud_cpp_accessapproval
 add_library(google-cloud-cpp::experimental-accessapproval ALIAS
             google_cloud_cpp_accessapproval)
 
-# To avoid maintaining the list of files for the library, export them to a .bzl
-# file.
-include(CreateBazelConfig)
-create_bazel_config(google_cloud_cpp_accessapproval YEAR "2021")
-
 # Create a header-only library for the mocks. We use a CMake `INTERFACE` library
 # for these, a regular library would not work on macOS (where the library needs
 # at least one .o file). Unfortunately INTERFACE libraries are a bit weird in
@@ -109,7 +104,6 @@ target_link_libraries(
 set_target_properties(
     google_cloud_cpp_accessapproval_mocks
     PROPERTIES EXPORT_NAME google-cloud-cpp::experimental-accessapproval_mocks)
-create_bazel_config(google_cloud_cpp_accessapproval_mocks YEAR "2022")
 target_include_directories(
     google_cloud_cpp_accessapproval_mocks
     INTERFACE $<BUILD_INTERFACE:${PROJECT_SOURCE_DIR}>
@@ -166,7 +160,7 @@ set(GOOGLE_CLOUD_CONFIG_VERSION_MINOR ${PROJECT_VERSION_MINOR})
 set(GOOGLE_CLOUD_CONFIG_VERSION_PATCH ${PROJECT_VERSION_PATCH})
 set(GOOGLE_CLOUD_PC_NAME "The Access Approval API C++ Client Library")
 set(GOOGLE_CLOUD_PC_DESCRIPTION
-    "Provides C++ APIs to access Access Approval API.")
+    "Provides C++ APIs to use the Access Approval API.")
 set(GOOGLE_CLOUD_PC_LIBS "-lgoogle_cloud_cpp_accessapproval")
 string(CONCAT GOOGLE_CLOUD_PC_REQUIRES "google_cloud_cpp_grpc_utils"
               " google_cloud_cpp_common"

google/cloud/accessapproval/google_cloud_cpp_accessapproval.bzl

@@ -16,12 +16,24 @@ package(default_visibility = ["//visibility:private"])
 
 licenses(["notice"])  # Apache 2.0
 
-load(":google_cloud_cpp_assuredworkloads.bzl", "google_cloud_cpp_assuredworkloads_hdrs", "google_cloud_cpp_assuredworkloads_srcs")
+SOURCE_GLOB = "**/*.cc"
+
+MOCK_SOURCE_GLOB = "mocks/*.cc"
+
+HEADER_GLOB = "**/*.h"
+
+MOCK_HEADER_GLOB = "mocks/*.h"
 
 cc_library(
     name = "google_cloud_cpp_assuredworkloads",
-    srcs = google_cloud_cpp_assuredworkloads_srcs,
-    hdrs = google_cloud_cpp_assuredworkloads_hdrs,
+    srcs = glob(
+        include = [SOURCE_GLOB],
+        exclude = [MOCK_SOURCE_GLOB],
+    ),
+    hdrs = glob(
+        include = [HEADER_GLOB],
+        exclude = [MOCK_HEADER_GLOB],
+    ),
     visibility = ["//:__pkg__"],
     deps = [
         "//google/cloud:google_cloud_cpp_common",
@@ -30,12 +42,14 @@ cc_library(
     ],
 )
 
-load(":google_cloud_cpp_assuredworkloads_mocks.bzl", "google_cloud_cpp_assuredworkloads_mocks_hdrs", "google_cloud_cpp_assuredworkloads_mocks_srcs")
-
 cc_library(
     name = "google_cloud_cpp_assuredworkloads_mocks",
-    srcs = google_cloud_cpp_assuredworkloads_mocks_srcs,
-    hdrs = google_cloud_cpp_assuredworkloads_mocks_hdrs,
+    srcs = glob(
+        include = [MOCK_SOURCE_GLOB],
+    ),
+    hdrs = glob(
+        include = [MOCK_HEADER_GLOB],
+    ),
     visibility = ["//:__pkg__"],
     deps = [
         ":google_cloud_cpp_assuredworkloads",

google/cloud/accessapproval/google_cloud_cpp_accessapproval_mocks.bzl

@@ -85,11 +85,6 @@ target_compile_options(google_cloud_cpp_assuredworkloads
 add_library(google-cloud-cpp::experimental-assuredworkloads ALIAS
             google_cloud_cpp_assuredworkloads)
 
-# To avoid maintaining the list of files for the library, export them to a .bzl
-# file.
-include(CreateBazelConfig)
-create_bazel_config(google_cloud_cpp_assuredworkloads YEAR "2021")
-
 # Create a header-only library for the mocks. We use a CMake `INTERFACE` library
 # for these, a regular library would not work on macOS (where the library needs
 # at least one .o file). Unfortunately INTERFACE libraries are a bit weird in
@@ -113,7 +108,6 @@ set_target_properties(
     google_cloud_cpp_assuredworkloads_mocks
     PROPERTIES EXPORT_NAME
                google-cloud-cpp::experimental-assuredworkloads_mocks)
-create_bazel_config(google_cloud_cpp_assuredworkloads_mocks YEAR "2022")
 target_include_directories(
     google_cloud_cpp_assuredworkloads_mocks
     INTERFACE $<BUILD_INTERFACE:${PROJECT_SOURCE_DIR}>
@@ -171,7 +165,7 @@ set(GOOGLE_CLOUD_CONFIG_VERSION_MINOR ${PROJECT_VERSION_MINOR})
 set(GOOGLE_CLOUD_CONFIG_VERSION_PATCH ${PROJECT_VERSION_PATCH})
 set(GOOGLE_CLOUD_PC_NAME "The Assured Workloads API C++ Client Library")
 set(GOOGLE_CLOUD_PC_DESCRIPTION
-    "Provides C++ APIs to access Assured Workloads API.")
+    "Provides C++ APIs to use the Assured Workloads API.")
 set(GOOGLE_CLOUD_PC_LIBS "-lgoogle_cloud_cpp_assuredworkloads")
 string(CONCAT GOOGLE_CLOUD_PC_REQUIRES "google_cloud_cpp_grpc_utils"
               " google_cloud_cpp_common"

google/cloud/assuredworkloads/BUILD.bazel

@@ -16,12 +16,24 @@ package(default_visibility = ["//visibility:private"])
 
 licenses(["notice"])  # Apache 2.0
 
-load(":google_cloud_cpp_billing.bzl", "google_cloud_cpp_billing_hdrs", "google_cloud_cpp_billing_srcs")
+SOURCE_GLOB = "**/*.cc"
+
+MOCK_SOURCE_GLOB = "mocks/*.cc"
+
+HEADER_GLOB = "**/*.h"
+
+MOCK_HEADER_GLOB = "mocks/*.h"
 
 cc_library(
     name = "google_cloud_cpp_billing",
-    srcs = google_cloud_cpp_billing_srcs,
-    hdrs = google_cloud_cpp_billing_hdrs,
+    srcs = glob(
+        include = [SOURCE_GLOB],
+        exclude = [MOCK_SOURCE_GLOB],
+    ),
+    hdrs = glob(
+        include = [HEADER_GLOB],
+        exclude = [MOCK_HEADER_GLOB],
+    ),
     visibility = ["//:__pkg__"],
     deps = [
         "//google/cloud:google_cloud_cpp_common",
@@ -31,12 +43,14 @@ cc_library(
     ],
 )
 
-load(":google_cloud_cpp_billing_mocks.bzl", "google_cloud_cpp_billing_mocks_hdrs", "google_cloud_cpp_billing_mocks_srcs")
-
 cc_library(
     name = "google_cloud_cpp_billing_mocks",
-    srcs = google_cloud_cpp_billing_mocks_srcs,
-    hdrs = google_cloud_cpp_billing_mocks_hdrs,
+    srcs = glob(
+        include = [MOCK_SOURCE_GLOB],
+    ),
+    hdrs = glob(
+        include = [MOCK_HEADER_GLOB],
+    ),
     visibility = ["//:__pkg__"],
     deps = [
         ":google_cloud_cpp_billing",

google/cloud/assuredworkloads/CMakeLists.txt

@@ -93,11 +93,6 @@ target_compile_options(google_cloud_cpp_billing
 add_library(google-cloud-cpp::experimental-billing ALIAS
             google_cloud_cpp_billing)
 
-# To avoid maintaining the list of files for the library, export them to a .bzl
-# file.
-include(CreateBazelConfig)
-create_bazel_config(google_cloud_cpp_billing YEAR "2021")
-
 # Create a header-only library for the mocks. We use a CMake `INTERFACE` library
 # for these, a regular library would not work on macOS (where the library needs
 # at least one .o file). Unfortunately INTERFACE libraries are a bit weird in
@@ -120,7 +115,6 @@ target_link_libraries(
 set_target_properties(
     google_cloud_cpp_billing_mocks
     PROPERTIES EXPORT_NAME google-cloud-cpp::experimental-billing_mocks)
-create_bazel_config(google_cloud_cpp_billing_mocks YEAR "2022")
 target_include_directories(
     google_cloud_cpp_billing_mocks
     INTERFACE $<BUILD_INTERFACE:${PROJECT_SOURCE_DIR}>
@@ -175,7 +169,7 @@ set(GOOGLE_CLOUD_CONFIG_VERSION_MINOR ${PROJECT_VERSION_MINOR})
 set(GOOGLE_CLOUD_CONFIG_VERSION_PATCH ${PROJECT_VERSION_PATCH})
 set(GOOGLE_CLOUD_PC_NAME "The Cloud Billing Budget API C++ Client Library")
 set(GOOGLE_CLOUD_PC_DESCRIPTION
-    "Provides C++ APIs to access Cloud Billing Budget API.")
+    "Provides C++ APIs to use the Cloud Billing Budget API.")
 set(GOOGLE_CLOUD_PC_LIBS "-lgoogle_cloud_cpp_billing")
 string(CONCAT GOOGLE_CLOUD_PC_REQUIRES "google_cloud_cpp_grpc_utils"
               " google_cloud_cpp_common" " google_cloud_cpp_billing_protos")