Skip to content

Commit 9d6152e

Browse files
committed
correct the test
1 parent 1c02ea3 commit 9d6152e

File tree

2 files changed

+2
-14
lines changed

2 files changed

+2
-14
lines changed

google/cloud/storage/tests/object_checksum_integration_test.cc

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -330,12 +330,6 @@ TEST_F(ObjectChecksumIntegrationTest, WriteObjectWithIncorrectChecksumValue) {
330330
EXPECT_TRUE(os.bad());
331331
auto meta = os.metadata();
332332
EXPECT_THAT(meta, Not(IsOk()));
333-
334-
if(UsingGrpc()) {
335-
EXPECT_THAT(meta, StatusIs(StatusCode::kInvalidArgument));
336-
return;
337-
}
338-
EXPECT_THAT(meta, StatusIs(StatusCode::kFailedPrecondition));
339333
}
340334

341335
/// @test Verify that CRC32C checksums are computed by default on downloads.

google/cloud/storage/tests/object_hash_integration_test.cc

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -192,14 +192,8 @@ TEST_F(ObjectHashIntegrationTest, WriteObjectExplicitEnable) {
192192
EXPECT_THAT(os.computed_hash(), HasSubstr(ComputeMD5Hash(LoremIpsum())));
193193
EXPECT_THAT(os.received_hash(), HasSubstr(ComputeMD5Hash(LoremIpsum())));
194194
if (meta->has_metadata("x_emulator_upload")) {
195-
if (UsingGrpc()) {
196-
EXPECT_THAT(meta->metadata(), Contains(Pair("x_emulator_no_crc32c", _)));
197-
EXPECT_THAT(meta->metadata(), Contains(Pair("x_emulator_md5", _)));
198-
} else {
199-
// REST cannot send the checksums computed at the end of the upload.
200-
EXPECT_THAT(meta->metadata(), Contains(Pair("x_emulator_no_crc32c", _)));
201-
EXPECT_THAT(meta->metadata(), Contains(Pair("x_emulator_no_md5", _)));
202-
}
195+
EXPECT_THAT(meta->metadata(), Contains(Pair("x_emulator_no_crc32c", _)));
196+
EXPECT_THAT(meta->metadata(), Contains(Pair("x_emulator_md5", _)));
203197
}
204198
}
205199

0 commit comments

Comments
 (0)