cleanup(otel)!: Drop Options from resource detector API. (#12730)

Author: dbolduc

google/cloud/opentelemetry/configure_basic_tracing.cc

@@ -60,7 +60,7 @@ std::unique_ptr<BasicTracingConfiguration> ConfigureBasicTracing(
   auto ratio = options.has<BasicTracingRateOption>()
                    ? options.get<BasicTracingRateOption>()
                    : 1.0;
-  auto detector = MakeResourceDetector(options);
+  auto detector = MakeResourceDetector();
   auto processor =
       std::make_unique<opentelemetry::sdk::trace::BatchSpanProcessor>(
           MakeTraceExporter(std::move(project), std::move(options)),

google/cloud/opentelemetry/resource_detector.cc

@@ -23,7 +23,7 @@ namespace otel {
 GOOGLE_CLOUD_CPP_INLINE_NAMESPACE_BEGIN
 
 std::unique_ptr<opentelemetry::sdk::resource::ResourceDetector>
-MakeResourceDetector(Options options) {
+MakeResourceDetector() {
   auto retry = internal::LimitedTimeRetryPolicy<otel_internal::StatusTraits>(
       std::chrono::seconds(10));
   auto backoff =
@@ -33,7 +33,7 @@ MakeResourceDetector(Options options) {
       [](Options const& options) {
         return rest_internal::MakeDefaultRestClient("", options);
       },
-      retry.clone(), backoff.clone(), std::move(options));
+      retry.clone(), backoff.clone(), Options{});
 }
 
 GOOGLE_CLOUD_CPP_INLINE_NAMESPACE_END

google/cloud/opentelemetry/resource_detector.h

@@ -27,7 +27,7 @@ GOOGLE_CLOUD_CPP_INLINE_NAMESPACE_BEGIN
 
 /// Make an OpenTelemetry Resource Detector for Google Cloud Platform.
 std::unique_ptr<opentelemetry::sdk::resource::ResourceDetector>
-MakeResourceDetector(Options options = {});
+MakeResourceDetector();
 
 GOOGLE_CLOUD_CPP_INLINE_NAMESPACE_END
 }  // namespace otel