feat(bigtable): introduce minimal DataConnection implementation (#15651)

* feat(bigtable): introduce minimal DataConnection implementation

Author: mpeddada1

google/cloud/bigtable/data_connection.cc

@@ -20,6 +20,7 @@
 #include "google/cloud/bigtable/internal/mutate_rows_limiter.h"
 #include "google/cloud/bigtable/internal/row_reader_impl.h"
 #include "google/cloud/bigtable/options.h"
+#include "google/cloud/bigtable/results.h"
 #include "google/cloud/background_threads.h"
 #include "google/cloud/common_options.h"
 #include "google/cloud/credentials.h"
@@ -156,6 +157,21 @@ future<StatusOr<std::pair<bool, Row>>> DataConnection::AsyncReadRow(
       Status(StatusCode::kUnimplemented, "not implemented"));
 }
 
+StatusOr<bigtable::PreparedQuery> DataConnection::PrepareQuery(
+    bigtable::PrepareQueryParams const&) {
+  return Status(StatusCode::kUnimplemented, "not implemented");
+}
+future<StatusOr<bigtable::PreparedQuery>> DataConnection::AsyncPrepareQuery(
+    bigtable::PrepareQueryParams const&) {
+  return make_ready_future<StatusOr<PreparedQuery>>(
+      Status(StatusCode::kUnimplemented, "not implemented"));
+}
+
+StatusOr<bigtable::RowStream> DataConnection::ExecuteQuery(
+    bigtable::ExecuteQueryParams const&) {
+  return Status(StatusCode::kUnimplemented, "not implemented");
+}
+
 std::shared_ptr<DataConnection> MakeDataConnection(Options options) {
   google::cloud::internal::CheckExpectedOptions<
       AppProfileIdOption, CommonOptionList, GrpcOptionList,

google/cloud/bigtable/data_connection.h

@@ -19,10 +19,13 @@
 #include "google/cloud/bigtable/internal/bigtable_stub.h"
 #include "google/cloud/bigtable/mutation_branch.h"
 #include "google/cloud/bigtable/mutations.h"
+#include "google/cloud/bigtable/prepared_query.h"
+#include "google/cloud/bigtable/results.h"
 #include "google/cloud/bigtable/row.h"
 #include "google/cloud/bigtable/row_key_sample.h"
 #include "google/cloud/bigtable/row_reader.h"
 #include "google/cloud/bigtable/row_set.h"
+#include "google/cloud/bigtable/sql_statement.h"
 #include "google/cloud/backoff_policy.h"
 #include "google/cloud/options.h"
 #include "google/cloud/status_or.h"
@@ -52,6 +55,13 @@ struct ReadRowsParams {
   bool reverse = false;
 };
 
+struct PrepareQueryParams {
+  bigtable::InstanceResource instance;
+  bigtable::SqlStatement sql_statement;
+};
+
+struct ExecuteQueryParams {};
+
 /**
  * A connection to the Cloud Bigtable Data API.
  *
@@ -143,6 +153,13 @@ class DataConnection {
 
   virtual future<StatusOr<std::pair<bool, Row>>> AsyncReadRow(
       std::string const& table_name, std::string row_key, Filter filter);
+
+  virtual StatusOr<bigtable::PreparedQuery> PrepareQuery(
+      bigtable::PrepareQueryParams const& p);
+  virtual future<StatusOr<bigtable::PreparedQuery>> AsyncPrepareQuery(
+      bigtable::PrepareQueryParams const& p);
+  virtual StatusOr<bigtable::RowStream> ExecuteQuery(
+      bigtable::ExecuteQueryParams const& p);
 };
 
 /**

google/cloud/bigtable/internal/data_connection_impl.cc

@@ -21,6 +21,7 @@
 #include "google/cloud/bigtable/internal/defaults.h"
 #include "google/cloud/bigtable/internal/operation_context.h"
 #include "google/cloud/bigtable/options.h"
+#include "google/cloud/bigtable/results.h"
 #include "google/cloud/background_threads.h"
 #include "google/cloud/grpc_options.h"
 #include "google/cloud/idempotency.h"
@@ -617,6 +618,22 @@ DataConnectionImpl::AsyncReadRow(std::string const& table_name,
   return handler->GetFuture();
 }
 
+StatusOr<bigtable::PreparedQuery> DataConnectionImpl::PrepareQuery(
+    bigtable::PrepareQueryParams const&) {
+  return Status(StatusCode::kUnimplemented, "not implemented");
+}
+
+future<StatusOr<bigtable::PreparedQuery>> DataConnectionImpl::AsyncPrepareQuery(
+    bigtable::PrepareQueryParams const&) {
+  return make_ready_future<StatusOr<bigtable::PreparedQuery>>(
+      Status(StatusCode::kUnimplemented, "not implemented"));
+}
+
+StatusOr<bigtable::RowStream> DataConnectionImpl::ExecuteQuery(
+    bigtable::ExecuteQueryParams const&) {
+  return Status(StatusCode::kUnimplemented, "not implemented");
+};
+
 GOOGLE_CLOUD_CPP_INLINE_NAMESPACE_END
 }  // namespace bigtable_internal
 }  // namespace cloud

google/cloud/bigtable/internal/data_connection_impl.h

@@ -19,6 +19,8 @@
 #include "google/cloud/bigtable/internal/bigtable_stub.h"
 #include "google/cloud/bigtable/internal/mutate_rows_limiter.h"
 #include "google/cloud/bigtable/internal/operation_context_factory.h"
+#include "google/cloud/bigtable/prepared_query.h"
+#include "google/cloud/bigtable/results.h"
 #include "google/cloud/background_threads.h"
 #include "google/cloud/options.h"
 #include "google/cloud/status_or.h"
@@ -101,6 +103,13 @@ class DataConnectionImpl : public bigtable::DataConnection {
       std::string const& table_name, std::string row_key,
       bigtable::Filter filter) override;
 
+  StatusOr<bigtable::PreparedQuery> PrepareQuery(
+      bigtable::PrepareQueryParams const& p) override;
+  future<StatusOr<bigtable::PreparedQuery>> AsyncPrepareQuery(
+      bigtable::PrepareQueryParams const& p) override;
+  StatusOr<bigtable::RowStream> ExecuteQuery(
+      bigtable::ExecuteQueryParams const& p) override;
+
  private:
   void AsyncReadRowsHelper(std::string const& table_name,
                            std::function<future<bool>(bigtable::Row)> on_row,

google/cloud/bigtable/internal/data_connection_impl_test.cc

@@ -20,6 +20,7 @@
 #include "google/cloud/testing_util/fake_clock.h"
 #endif
 #include "google/cloud/bigtable/options.h"
+#include "google/cloud/bigtable/sql_statement.h"
 #include "google/cloud/bigtable/testing/mock_bigtable_stub.h"
 #include "google/cloud/bigtable/testing/mock_mutate_rows_limiter.h"
 #include "google/cloud/bigtable/testing/mock_policies.h"
@@ -2722,6 +2723,22 @@ TEST_F(DataConnectionTest, AsyncReadRowFailure) {
   EXPECT_THAT(resp, StatusIs(StatusCode::kPermissionDenied));
 }
 
+TEST_F(DataConnectionTest, ExecuteQuery) {
+  auto conn = TestConnection(std::make_shared<MockBigtableStub>());
+  internal::OptionsSpan span(CallOptions());
+  EXPECT_THAT(conn->ExecuteQuery(bigtable::ExecuteQueryParams{}),
+              StatusIs(StatusCode::kUnimplemented));
+}
+
+TEST_F(DataConnectionTest, PrepareQuery) {
+  auto conn = TestConnection(std::make_shared<MockBigtableStub>());
+  internal::OptionsSpan span(CallOptions());
+  EXPECT_THAT(conn->PrepareQuery(bigtable::PrepareQueryParams{
+                  bigtable::InstanceResource(google::cloud::Project(""), ""),
+                  bigtable::SqlStatement("")}),
+              StatusIs(StatusCode::kUnimplemented));
+}
+
 }  // namespace
 GOOGLE_CLOUD_CPP_INLINE_NAMESPACE_END
 }  // namespace bigtable_internal