Skip to content

Commit be5767c

Browse files
authored
cleanup(gcb): move 12 Dockerfiles to a dockerfiles/ dir (#6246)
We're already up to 12 Dockerfiles, and it's getting noisy in the ci/cloudbuild/ dir. Moving these to a subdir cleans things up a bit.
1 parent 679d58f commit be5767c

14 files changed

+7
-7
lines changed

ci/cloudbuild/build.sh

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -27,13 +27,13 @@
2727
#
2828
# This script runs named builds, where builds are defined as a build script
2929
# (which lives in `ci/cloudbuild/builds/`) and a distro (which is defined in
30-
# `ci/cloudbuild/<distro>.Dockerfile`). Trigger files (which live in
31-
# `ci/cloudbuild/triggers/`) associate build scripts with the distro they're
30+
# `ci/cloudbuild/dockerfiles/<distro>.Dockerfile`). Trigger files (which live
31+
# in `ci/cloudbuild/triggers/`) associate build scripts with the distro they're
3232
# intended to run on. For example, the "asan-pr" build is defined in the
3333
# `ci/cloudbuild/triggers/asan-pr.yaml` file, which specifies that the
3434
# `ci/cloudbuild/builds/asan.sh` script should be run on the
35-
# `ci/cloudbuild/fedora.Dockerfile` image. There are a couple ways to specify
36-
# builds:
35+
# `ci/cloudbuild/dockerfiles/fedora.Dockerfile` image. There are a couple ways
36+
# to specify builds:
3737
#
3838
# 1. Explicitly name the distro and build script. For example:
3939
# $ build.sh --distro fedora asan
@@ -212,7 +212,7 @@ if [[ "${DOCKER_FLAG}" = "true" ]]; then
212212
image="gcb-${DISTRO_FLAG}:latest"
213213
io::log_h2 "Building docker image: ${image}"
214214
docker build -t "${image}" "--build-arg=NCPU=$(nproc)" \
215-
-f "ci/cloudbuild/${DISTRO_FLAG}.Dockerfile" ci
215+
-f "ci/cloudbuild/dockerfiles/${DISTRO_FLAG}.Dockerfile" ci
216216
io::log_h2 "Starting container for ${image} running ${BUILD_NAME}"
217217
run_flags=(
218218
"--interactive"
@@ -241,7 +241,7 @@ if [[ "${DOCKER_FLAG}" = "true" ]]; then
241241
fi
242242

243243
# Surface invalid arguments early rather than waiting for GCB to fail.
244-
if [ ! -r "${PROGRAM_DIR}/${DISTRO_FLAG}.Dockerfile" ]; then
244+
if [ ! -r "${PROGRAM_DIR}/dockerfiles/${DISTRO_FLAG}.Dockerfile" ]; then
245245
io::log_red "Unknown distro: ${DISTRO_FLAG}"
246246
print_usage
247247
exit 1

ci/cloudbuild/cloudbuild.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ steps:
4545
- name: 'gcr.io/kaniko-project/executor:edge'
4646
args: [
4747
'--context=dir:///workspace/ci',
48-
'--dockerfile=ci/cloudbuild/${_DISTRO}.Dockerfile',
48+
'--dockerfile=ci/cloudbuild/dockerfiles/${_DISTRO}.Dockerfile',
4949
'--cache=true',
5050
'--destination=gcr.io/${PROJECT_ID}/${_IMAGE}:${BUILD_ID}',
5151
]
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.

0 commit comments

Comments
 (0)