Skip to content

Commit d35d72f

Browse files
authored
test(spanner): enable testing of PG JSONB[] support (#10475)
The backend now supports PG JSONB arrays. Fixes #10095.
1 parent 5fd09c3 commit d35d72f

File tree

2 files changed

+1
-11
lines changed

2 files changed

+1
-11
lines changed

google/cloud/spanner/integration_tests/data_types_integration_test.cc

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -417,16 +417,6 @@ TEST_F(PgDataTypeIntegrationTest, WriteReadArrayJson) {
417417
},
418418
};
419419
auto result = WriteReadData(*client_, data, "ArrayJsonValue");
420-
{
421-
// TODO(#10095): Remove this when JSONB[] is supported.
422-
auto matcher = StatusIs(StatusCode::kNotFound,
423-
AnyOf(HasSubstr("Column not found in table"),
424-
HasSubstr("is not a column in")));
425-
testing::StringMatchResultListener listener;
426-
if (matcher.impl().MatchAndExplain(result, &listener)) {
427-
GTEST_SKIP();
428-
}
429-
}
430420
ASSERT_STATUS_OK(result);
431421
EXPECT_THAT(*result, UnorderedElementsAreArray(data));
432422
}

google/cloud/spanner/testing/database_integration_test.cc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -215,7 +215,7 @@ void PgDatabaseIntegrationTest::SetUpTestSuite() {
215215
ArrayBytesValue BYTEA[],
216216
ArrayTimestampValue TIMESTAMP WITH TIME ZONE[],
217217
ArrayDateValue DATE[],
218-
-- TODO(#10095): ArrayJsonValue JSONB[],
218+
ArrayJsonValue JSONB[],
219219
ArrayNumericValue NUMERIC[],
220220
PRIMARY KEY(Id)
221221
)

0 commit comments

Comments
 (0)