Skip to content

Commit d72883a

Browse files
authored
ci(check-api): use abi-dumper w/ integer overflow fix (#7098)
Pulls in the fix from lvc/abi-dumper#29 This will remove log spew that looks like: ... Integer overflow in hexadecimal number at /usr/bin/abi-dumper line 1496, <$INFO_fh> line 6783817. ... Example: GCB: https://console.cloud.google.com/cloud-build/builds;region=us-east1/cb9409ba-1ccc-47ae-a233-01c6ebe8f075;tab=detail?project=cloud-cpp-testing-resources Raw: https://storage.googleapis.com/cloud-cpp-community-publiclogs/logs/google-cloud-cpp/main/017cddfefc34c1a2a4c750bd58468dc3b06ae3eb/fedora-34-check-api/log-cb9409ba-1ccc-47ae-a233-01c6ebe8f075.txt
1 parent 88f748c commit d72883a

9 files changed

+10
-1
lines changed
21 Bytes
Binary file not shown.
33 Bytes
Binary file not shown.
5 Bytes
Binary file not shown.
17 Bytes
Binary file not shown.
28 Bytes
Binary file not shown.
40 Bytes
Binary file not shown.
43 Bytes
Binary file not shown.
40 Bytes
Binary file not shown.

ci/cloudbuild/dockerfiles/fedora-34.Dockerfile

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ ARG NCPU=4
1919
# for `google-cloud-cpp`. Install these packages and additional development
2020
# tools to compile the dependencies:
2121
RUN dnf makecache && \
22-
dnf install -y abi-compliance-checker abi-dumper autoconf automake \
22+
dnf install -y abi-compliance-checker autoconf automake \
2323
ccache clang clang-analyzer clang-tools-extra \
2424
cmake diffutils doxygen findutils gcc-c++ git \
2525
lcov libcxx-devel libcxxabi-devel \
@@ -170,6 +170,15 @@ RUN curl -sSL https://github.com/universal-ctags/ctags/archive/refs/tags/p5.9.20
170170
make install && \
171171
cd /var/tmp && rm -fr build
172172

173+
# Installs the abi-dumper with the integer overflow fix from
174+
# https://github.com/lvc/abi-dumper/pull/29. We can switch back to `dnf install
175+
# abi-dumper` once it has the fix.
176+
WORKDIR /var/tmp/build
177+
RUN curl -sSL https://github.com/lvc/abi-dumper/archive/814effec0f20a9613441dfa033aa0a0bc2a96a87.tar.gz | \
178+
tar -xzf - --strip-components=1 && \
179+
mv abi-dumper.pl /usr/local/bin/abi-dumper && \
180+
chmod +x /usr/local/bin/abi-dumper
181+
173182
# Install the Cloud SDK and some of the emulators. We use the emulators to run
174183
# integration tests for the client libraries.
175184
COPY . /var/tmp/ci

0 commit comments

Comments
 (0)