chore(storage): minor corrections for performance while pushing back unreachable buckets to vector

bajajneha27 · bajajneha27 · commit df2570e0d0bf · 2025-11-27T11:15:50.000Z
diff --git a/google/cloud/storage/internal/bucket_requests.cc b/google/cloud/storage/internal/bucket_requests.cc
@@ -245,7 +245,7 @@ StatusOr<ListBucketsResponse> ListBucketsResponse::FromHttpResponse(
 
   if (json.count("unreachable") != 0) {
     for (auto const& kv : json["unreachable"].items()) {
-      result.unreachable.emplace_back(kv.value().get<std::string>());
+      result.unreachable.push_back(kv.value().get<std::string>());
     }
   }
 
diff --git a/google/cloud/storage/well_known_parameters.h b/google/cloud/storage/well_known_parameters.h
@@ -595,7 +595,7 @@ struct RequestedPolicyVersion
  *
  * By default requests listing resources only includs the latest (live) version
  * of each resource, set this option to `true` to get list of unreachable
- * regions.
+ * resources.
  */
 struct ReturnPartialSuccess
     : public internal::WellKnownParameter<ReturnPartialSuccess, bool> {

Original file line number	Diff line number	Diff line change
`@@ -245,7 +245,7 @@ StatusOr<ListBucketsResponse> ListBucketsResponse::FromHttpResponse(`
`245`	`245`
`246`	`246`	`if (json.count("unreachable") != 0) {`
`247`	`247`	`for (auto const& kv : json["unreachable"].items()) {`
`248`		`- result.unreachable.emplace_back(kv.value().get<std::string>());`
	`248`	`+ result.unreachable.push_back(kv.value().get<std::string>());`
`249`	`249`	`}`
`250`	`250`	`}`
`251`	`251`
Original file line number	Diff line number	Diff line change
`@@ -595,7 +595,7 @@ struct RequestedPolicyVersion`
`595`	`595`	`*`
`596`	`596`	`* By default requests listing resources only includs the latest (live) version`
`597`	`597`	* of each resource, set this option to `true` to get list of unreachable
`598`		`- * regions.`
	`598`	`+ * resources.`
`599`	`599`	`*/`
`600`	`600`	`struct ReturnPartialSuccess`
`601`	`601`	`: public internal::WellKnownParameter<ReturnPartialSuccess, bool> {`