Skip to content

Commit dfd6de9

Browse files
authored
fix: gcb coverage build (#6273)
The coverage build [failed][failure-log] with (error omitted because conventionalcommits bot can't handle it) I'm not sure why that failed, but in looking into it, I noticed I was missing some needed flags for coverage, so maybe this is the problem and will fix it. Note, that I was unable to reproduce the failure in any of my tests, so I'm not sure if this will fix it, but I think we need these flags anyway. [failure-log]: https://pantheon.corp.google.com/cloud-build/builds;region=global/5f4c6f26-4330-44bd-8415-b75c43be2276;step=2?project=cloud-cpp-testing-resources
1 parent be2c7d3 commit dfd6de9

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

ci/cloudbuild/builds/coverage.sh

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,8 @@ export CC=gcc
2424
export CXX=g++
2525

2626
mapfile -t args < <(bazel::common_args)
27+
args+=("--instrumentation_filter=/google/cloud[/:],/generator[/:]")
28+
args+=("--instrument_test_targets")
2729
bazel coverage "${args[@]}" --test_tag_filters=-integration-test ...
2830
mapfile -t integration_args < <(integration::args)
2931
integration::bazel_with_emulators coverage "${args[@]}" "${integration_args[@]}"

0 commit comments

Comments
 (0)