impl(bigquerycontrol): promote from experimental to transitional (#14887)

scotthart · web-flow · commit e2ed1e699d90 · 2024-12-11T13:04:20.000-05:00
diff --git a/README.md b/README.md
@@ -140,6 +140,9 @@ See each library's `README.md` file for more information about:
 - [Google Cloud BigQuery](google/cloud/bigquery/README.md)
   [[quickstart]](google/cloud/bigquery/quickstart/README.md)
   [[reference]](https://cloud.google.com/cpp/docs/reference/bigquery/latest)
+- [BigQuery API](google/cloud/bigquerycontrol/README.md)
+  [[quickstart]](google/cloud/bigquerycontrol/quickstart/README.md)
+  [[reference]](https://cloud.google.com/cpp/docs/reference/bigquerycontrol/latest)
 - [Google Cloud Bigtable](google/cloud/bigtable/README.md)
   [[quickstart]](google/cloud/bigtable/quickstart/README.md)
   [[reference]](https://cloud.google.com/cpp/docs/reference/bigtable/latest)
diff --git a/ci/abi-dumps/google_cloud_cpp_bigquerycontrol.expected.abi.dump.gz b/ci/abi-dumps/google_cloud_cpp_bigquerycontrol.expected.abi.dump.gz
diff --git a/cmake/GoogleCloudCppFeatures.cmake b/cmake/GoogleCloudCppFeatures.cmake
@@ -33,12 +33,11 @@ set(GOOGLE_CLOUD_CPP_NO_GRPC_FEATURES
 
 set(GOOGLE_CLOUD_CPP_EXPERIMENTAL_LIBRARIES
     # cmake-format: sort
-    "bigquerycontrol" # Some proto RPC comments indicate experimental methods.
     "pubsublite" # This is WIP, it needs a number of hand-crafted APIs.
 )
 
 set(GOOGLE_CLOUD_CPP_TRANSITION_LIBRARIES # cmake-format: sort
-                                          "storage_grpc")
+                                          "bigquerycontrol" "storage_grpc")
 
 set(GOOGLE_CLOUD_CPP_GA_LIBRARIES
     # cmake-format: sort
diff --git a/google/cloud/bigquerycontrol/BUILD.bazel b/google/cloud/bigquerycontrol/BUILD.bazel
@@ -84,7 +84,7 @@ cc_library(
     srcs = [sample],
     tags = ["integration-test"],
     deps = [
-        "//:experimental-bigquerycontrol",
+        "//:bigquerycontrol",
         "//google/cloud/testing_util:google_cloud_cpp_testing_private",
     ],
 ) for sample in glob([d + "samples/*.cc" for d in service_dirs])]
diff --git a/google/cloud/bigquerycontrol/CMakeLists.txt b/google/cloud/bigquerycontrol/CMakeLists.txt
@@ -16,15 +16,13 @@
 
 include(GoogleCloudCppLibrary)
 
-google_cloud_cpp_add_gapic_library(
-    bigquerycontrol "Cloud BigQuery Control API" EXPERIMENTAL REST_TRANSPORT
-    SERVICE_DIRS "v2/")
+google_cloud_cpp_add_gapic_library(bigquerycontrol "Cloud BigQuery Control API"
+                                   TRANSITION REST_TRANSPORT SERVICE_DIRS "v2/")
 
 if (BUILD_TESTING AND GOOGLE_CLOUD_CPP_ENABLE_CXX_EXCEPTIONS)
     add_executable(bigquerycontrol_quickstart "quickstart/quickstart.cc")
-    target_link_libraries(
-        bigquerycontrol_quickstart
-        PRIVATE google-cloud-cpp::experimental-bigquerycontrol)
+    target_link_libraries(bigquerycontrol_quickstart
+                          PRIVATE google-cloud-cpp::bigquerycontrol)
     google_cloud_cpp_add_common_options(bigquerycontrol_quickstart)
     add_test(
         NAME bigquerycontrol_quickstart
diff --git a/google/cloud/bigquerycontrol/README.md b/google/cloud/bigquerycontrol/README.md
@@ -1,16 +1,12 @@
 # BigQuery API C++ Client Library
 
-:construction:
-
 This directory contains an idiomatic C++ client library for the
 [BigQuery API][cloud-service-docs].
 
 A data platform for customers to create, manage, share and query data.
 
-This library is **experimental**. Its APIs are subject to change without notice.
-
-Please, note that the Google Cloud C++ client libraries do **not** follow
-[Semantic Versioning](https://semver.org/).
+While this library is **GA**, please note Google Cloud C++ client libraries do
+**not** follow [Semantic Versioning](https://semver.org/).
 
 ## Quickstart
 
diff --git a/google/cloud/bigquerycontrol/doc/main.dox b/google/cloud/bigquerycontrol/doc/main.dox
@@ -6,10 +6,8 @@ An idiomatic C++ client library for the [BigQuery API][cloud-service-docs].
 
 A data platform for customers to create, manage, share and query data.
 
-This library is **experimental**. Its APIs are subject to change without notice.
-
-Please, note that the Google Cloud C++ client libraries do **not** follow
-[Semantic Versioning](https://semver.org/).
+While this library is **GA**, please note Google Cloud C++ client libraries do
+ **not** follow [Semantic Versioning](https://semver.org/).
 
 @tableofcontents{HTML:2}
 
diff --git a/google/cloud/bigquerycontrol/integration_tests/BUILD.bazel b/google/cloud/bigquerycontrol/integration_tests/BUILD.bazel
@@ -24,7 +24,7 @@ licenses(["notice"])  # Apache 2.0
         "integration-test",
     ],
     deps = [
-        "//:experimental-bigquerycontrol",
+        "//:bigquerycontrol",
         "//google/cloud/testing_util:google_cloud_cpp_testing_private",
     ],
 ) for test in glob(["*_test.cc"])]
diff --git a/google/cloud/bigquerycontrol/integration_tests/CMakeLists.txt b/google/cloud/bigquerycontrol/integration_tests/CMakeLists.txt
@@ -31,9 +31,8 @@ foreach (fname ${bigquerycontrol_integration_tests})
     google_cloud_cpp_add_executable(target "bigquerycontrol" ${fname})
     target_link_libraries(
         ${target}
-        PRIVATE google-cloud-cpp::experimental-bigquerycontrol
-                google_cloud_cpp_testing GTest::gmock_main GTest::gmock
-                GTest::gtest)
+        PRIVATE google-cloud-cpp::bigquerycontrol google_cloud_cpp_testing
+                GTest::gmock_main GTest::gmock GTest::gtest)
     google_cloud_cpp_add_common_options(${target})
     add_test(NAME ${target} COMMAND ${target})
     set_tests_properties(
diff --git a/google/cloud/bigquerycontrol/quickstart/BUILD.bazel b/google/cloud/bigquerycontrol/quickstart/BUILD.bazel
@@ -20,6 +20,7 @@ cc_binary(
         "quickstart.cc",
     ],
     deps = [
+        # TODO(#14891): switch to GA target
         "@google_cloud_cpp//:experimental-bigquerycontrol",
     ],
 )
diff --git a/google/cloud/bigquerycontrol/quickstart/CMakeLists.txt b/google/cloud/bigquerycontrol/quickstart/CMakeLists.txt
@@ -29,4 +29,5 @@ endif ()
 
 # Define your targets.
 add_executable(quickstart quickstart.cc)
+# TODO(#14891): switch to GA target.
 target_link_libraries(quickstart google-cloud-cpp::experimental-bigquerycontrol)
diff --git a/google/cloud/bigquerycontrol/v2/samples/job_query_samples.cc b/google/cloud/bigquerycontrol/v2/samples/job_query_samples.cc
@@ -54,7 +54,7 @@ void ExecuteQueryJob(std::vector<std::string> const& argv) {
 
     bigquery_v2_proto::JobConfiguration config;
     *config.mutable_query() = query_config;
-    config.mutable_labels()->emplace("type", "sample");
+    (*config.mutable_labels())["type"] = "sample";
     bigquery_v2_proto::Job job;
     *job.mutable_configuration() = config;
     bigquery_v2_proto::InsertJobRequest job_request;
diff --git a/google/cloud/spanner/samples/samples.cc b/google/cloud/spanner/samples/samples.cc
@@ -1747,7 +1747,7 @@ void RestoreDatabaseWithEncryptionKeyCommand(std::vector<std::string> argv) {
 // [START spanner_restore_backup_with_MR_CMEK]
 void RestoreDatabaseWithMRCMEK(
     google::cloud::spanner_admin::DatabaseAdminClient client,
-    BackupIdentifier src, std::string const& database_id,
+    BackupIdentifier const& src, std::string const& database_id,
     std::vector<google::cloud::KmsKeyName> const& encryption_keys) {
   google::cloud::spanner::Database database(src.project_id, src.instance_id,
                                             database_id);
diff --git a/libraries.bzl b/libraries.bzl
@@ -17,11 +17,11 @@
 """Automatically generated unit tests list - DO NOT EDIT."""
 
 GOOGLE_CLOUD_CPP_EXPERIMENTAL_LIBRARIES = [
-    "bigquerycontrol",
     "pubsublite",
 ]
 
 GOOGLE_CLOUD_CPP_TRANSITION_LIBRARIES = [
+    "bigquerycontrol",
     "storage_grpc",
 ]
 

Original file line number	Diff line number	Diff line change
`@@ -20,6 +20,7 @@ cc_binary(`
`20`	`20`	`"quickstart.cc",`
`21`	`21`	`],`
`22`	`22`	`deps = [`
	`23`	`+ # TODO(#14891): switch to GA target`
`23`	`24`	`"@google_cloud_cpp//:experimental-bigquerycontrol",`
`24`	`25`	`],`
`25`	`26`	`)`