Skip to content

Commit f0f9bef

Browse files
authored
Fix other places where we mention http_archive(). (#2719)
We need to use `strip_prefix` with `http_archive()` or things don't work. In the last contributed PR I forgot about them.
1 parent ad4dc2d commit f0f9bef

File tree

4 files changed

+11
-7
lines changed

4 files changed

+11
-7
lines changed

ci/test-install/WORKSPACE

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,8 +20,9 @@ workspace(name="com_github_googleapis_google_cloud_cpp_test_install")
2020
#
2121
# http_archive(
2222
# name = "com_github_googleapis_google_cloud_cpp",
23-
# url = "http://github.com/googleapis/google-cloud-cpp/archive/v0.2.0.tar.gz",
24-
# sha256 = "5fa6577828e5f949178b13ed0411dd634527c9d2d8f00e433edbd6ef9e42a281",
23+
# url = "http://github.com/googleapis/google-cloud-cpp/archive/v0.9.0.tar.gz",
24+
# strip_prefix = "google-cloud-cpp-0.9.0",
25+
# sha256 = "a072103546cfa041ad8bfc599fe5a20c58e005a1a0ee18e94b2554dc3d485604",
2526
# )
2627
#
2728
# But we want to test that the *current* version is correct.

ci/test-readme/generate-install.sh

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -102,8 +102,9 @@ commands to your `WORKSPACE` file:
102102
# Update the version and SHA256 digest as needed.
103103
http_archive(
104104
name = "com_github_googleapis_google_cloud_cpp",
105-
url = "http://github.com/googleapis/google-cloud-cpp/archive/v0.7.0.tar.gz",
106-
sha256 = "06bc735a117ec7ea92ea580e7f2ffa4b1cd7539e0e04f847bf500588d7f0fe90",
105+
url = "http://github.com/googleapis/google-cloud-cpp/archive/v0.9.0.tar.gz",
106+
strip_prefix = "google-cloud-cpp-0.9.0",
107+
sha256 = "a072103546cfa041ad8bfc599fe5a20c58e005a1a0ee18e94b2554dc3d485604",
107108
)
108109
109110
load("@com_github_googleapis_google_cloud_cpp//bazel:google_cloud_cpp_deps.bzl", "google_cloud_cpp_deps")

google/cloud/bigtable/doc/bigtable-main.dox

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -102,7 +102,8 @@ and install the library, for example:
102102
http_archive(
103103
name = "com_github_googleapis_google_cloud_cpp",
104104
url = "http://github.com/googleapis/google-cloud-cpp/archive/v0.9.0.tar.gz",
105-
sha256 = "a072103546cfa041ad8bfc599fe5a20c58e005a1a0ee18e94b2554dc3d485604"
105+
strip_prefix = "google-cloud-cpp-0.9.0",
106+
sha256 = "a072103546cfa041ad8bfc599fe5a20c58e005a1a0ee18e94b2554dc3d485604",
106107
)
107108
@endcode
108109

google/cloud/storage/doc/storage-main.dox

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -121,8 +121,9 @@ and install the library, for example:
121121
# Change the version and SHA256 hash as needed.
122122
http_archive(
123123
name = "com_github_googleapis_google_cloud_cpp",
124-
url = "http://github.com/googleapis/google-cloud-cpp/archive/v0.8.1.tar.gz",
125-
sha256 = "f5600fdf3efd28e3142a60c20574e349511104fc6f658faf7974f6ae2def245a"
124+
url = "http://github.com/googleapis/google-cloud-cpp/archive/v0.9.0.tar.gz",
125+
strip_prefix = "google-cloud-cpp-0.9.0",
126+
sha256 = "a072103546cfa041ad8bfc599fe5a20c58e005a1a0ee18e94b2554dc3d485604",
126127
)
127128
@endcode
128129

0 commit comments

Comments
 (0)