Commit fcc3103
authored
This reverts commit 5b18a43.
We still saw a timeout from spanner backup test after 15 minutes: https://source.cloud.google.com/results/invocations/9d52df69-7276-47a5-891a-46237d11178d/targets/cloud-cpp%2Fgithub%2Fgoogle-cloud-cpp%2Fmaster%2Fdocker%2Fintegration/log
[ RUN ] BackupTestWithCleanup.BackupTestSuite
google/cloud/spanner/integration_tests/backup_integration_test.cc:169: Failure
Value of: backup
Expected: is OK
Actual: exhausted polling policy with no previous error [DEADLINE_EXCEEDED]
However, this was not a bazel timeout, it was a timeout in the code, I think, from this code:
google-cloud-cpp/google/cloud/spanner/testing/policies.h
Line 29 in 0bf38cf
auto constexpr kMaximumWaitTimeMinutes = 15;
I'm reverting this to stop the flakes. We should then re-enable the spanner backup tests after we've re-evaluated all the retries, timeouts, etc, and we understand why/where the tests take all the time.
1 parent fad7885 commit fcc3103
2 files changed
+3
-12
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
41 | 41 | | |
42 | 42 | | |
43 | 43 | | |
44 | | - | |
45 | | - | |
46 | | - | |
47 | | - | |
48 | | - | |
49 | | - | |
50 | | - | |
51 | | - | |
52 | | - | |
53 | | - | |
54 | | - | |
| 44 | + | |
55 | 45 | | |
56 | 46 | | |
57 | 47 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
95 | 95 | | |
96 | 96 | | |
97 | 97 | | |
98 | | - | |
| 98 | + | |
| 99 | + | |
99 | 100 | | |
100 | 101 | | |
101 | 102 | | |
| |||
0 commit comments