Skip to content

Commit ff6303f

Browse files
committed
fix CI failures
1 parent 5d0d507 commit ff6303f

File tree

5 files changed

+11
-8
lines changed

5 files changed

+11
-8
lines changed

google/cloud/storage/client.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -412,8 +412,8 @@ class Client {
412412
return client->ListBuckets(r);
413413
},
414414
[](internal::ListBucketsResponse res) {
415-
return std::vector<BucketsExtended>{
416-
BucketsExtended{std::move(res.items), std::move(res.unreachable)}};
415+
return std::vector<BucketsExtended>{BucketsExtended{
416+
std::move(res.items), std::move(res.unreachable)}};
417417
});
418418
}
419419

google/cloud/storage/examples/storage_client_initialization_samples.cc

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -137,7 +137,6 @@ void SetClientUniverseDomain(std::vector<std::string> const& argv) {
137137
" <bucket-name> <object-name>"};
138138
}
139139
//! [START storage_set_client_universe_domain] [set-client-universe-domain]
140-
namespace g = ::google::cloud;
141140
namespace gcs = ::google::cloud::storage;
142141
[](std::string const& bucket_name, std::string const& object_name) {
143142
google::cloud::Options options;

google/cloud/storage/internal/connection_impl_bucket_test.cc

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -81,11 +81,13 @@ TEST(StorageConnectionImpl, ListBucketsPartialResult) {
8181
auto client =
8282
StorageConnectionImpl::Create(std::move(mock), RetryTestOptions());
8383
google::cloud::internal::OptionsSpan span(client->options());
84-
auto response = client->ListBuckets(
85-
ListBucketsRequest("test-project").set_option(ReturnPartialSuccess(true)));
84+
auto response =
85+
client->ListBuckets(ListBucketsRequest("test-project")
86+
.set_option(ReturnPartialSuccess(true)));
8687
ASSERT_TRUE(response.ok());
8788
EXPECT_EQ(1, response->items.size());
88-
EXPECT_THAT(response->unreachable, ::testing::ElementsAre("projects/_/buckets/bucket1"));
89+
EXPECT_THAT(response->unreachable,
90+
::testing::ElementsAre("projects/_/buckets/bucket1"));
8991
}
9092

9193
TEST(StorageConnectionImpl, CreateBucketTooManyFailures) {

google/cloud/storage/internal/grpc/bucket_request_parser_test.cc

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -245,7 +245,9 @@ TEST(GrpcBucketRequestParser, ListBucketsPartialResult) {
245245

246246
auto const actual = FromProto(input);
247247
EXPECT_EQ(actual.next_page_token, "test-token");
248-
EXPECT_THAT(actual.unreachable, ElementsAre("projects/_/buckets/unreachable-bucket-1", "projects/_/buckets/unreachable-bucket-2"));
248+
EXPECT_THAT(actual.unreachable,
249+
ElementsAre("projects/_/buckets/unreachable-bucket-1",
250+
"projects/_/buckets/unreachable-bucket-2"));
249251
}
250252

251253
TEST(GrpcBucketRequestParser, LockBucketRetentionPolicyRequestAllOptions) {

google/cloud/storage/list_buckets_extended_reader.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,4 +41,4 @@ GOOGLE_CLOUD_CPP_INLINE_NAMESPACE_END
4141
} // namespace cloud
4242
} // namespace google
4343

44-
#endif // GOOGLE_CLOUD_CPP_GOOGLE_CLOUD_STORAGE_LIST_BUCKETS_PARTIAL_READER_H
44+
#endif // GOOGLE_CLOUD_CPP_GOOGLE_CLOUD_STORAGE_LIST_BUCKETS_EXTENDED_READER_H

0 commit comments

Comments
 (0)