Skip to content

Commit ff9d390

Browse files
committed
fix(spanner): correct chrono arithmetic in Interval integration test (#15163)
1 parent 85a6816 commit ff9d390

File tree

1 file changed

+9
-13
lines changed

1 file changed

+9
-13
lines changed

google/cloud/spanner/integration_tests/data_types_integration_test.cc

Lines changed: 9 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -530,19 +530,15 @@ SELECT ARRAY<INTERVAL>[INTERVAL '1-2 3 4:5:6.789123456' YEAR TO SECOND];)sql",
530530

531531
TEST_F(DataTypeIntegrationTest, SelectIntervalFromTimestampDiff) {
532532
if (UsingEmulator()) GTEST_SKIP();
533-
Interval expected_interval{
534-
std::chrono::duration_cast<std::chrono::nanoseconds>(
535-
std::chrono::hours(1))};
536-
auto const now_time_point = std::chrono::system_clock::now();
537-
std::time_t now_seconds =
538-
std::chrono::system_clock::to_time_t(now_time_point);
539-
std::time_t one_hour_later_seconds =
540-
std::chrono::system_clock::to_time_t(
541-
now_time_point + std::chrono::hours(1));
542-
543-
std::vector<std::vector<Timestamp>> const data = {std::vector<Timestamp>{
544-
MakeTimestamp(MakeTime(now_seconds, 0)).value(),
545-
MakeTimestamp(MakeTime(one_hour_later_seconds, 0)).value()}};
533+
534+
auto const t0 = std::chrono::system_clock::from_time_t(1234567890);
535+
auto const t1 = t0 + std::chrono::hours(1);
536+
537+
Interval expected_interval{t1 - t0};
538+
539+
std::vector<std::vector<Timestamp>> const data = {
540+
{MakeTimestamp(t0).value(), MakeTimestamp(t1).value()}};
541+
546542
auto result = WriteReadData(*client_, data, "ArrayTimestampValue");
547543
EXPECT_THAT(result, IsOkAndHolds(UnorderedElementsAreArray(data)));
548544

0 commit comments

Comments
 (0)