feat: prepare for breaking change in Protobuf C++ API. #14828
Conversation
Protobuf 6.30.0 will change the return types of Descriptor::name() and other methods to absl::string_view. This makes the code work both before and after such a change.
scotthart
left a comment
scotthart
left a comment
There was a problem hiding this comment.
Reviewable status: 0 of 4 files reviewed, 2 unresolved discussions (waiting on @evalon32)
google/cloud/spanner/internal/status_utils.cc line 19 at r1 (raw file):
#include "google/cloud/internal/status_payload_keys.h" #include "absl/strings/match.h" #include "absl/strings/str_cat.h"
Please use our wrapper for this header "google/cloud/internal/absl_str_cat_quiet.h"
google/cloud/spanner/testing/status_utils.cc line 17 at r1 (raw file):
#include "google/cloud/spanner/testing/status_utils.h" #include "google/cloud/grpc_error_delegate.h" #include "absl/strings/str_cat.h"
Please use our wrapper for this header "google/cloud/internal/absl_str_cat_quiet.h"
|
/gcbrun |
evalon32
left a comment
evalon32
left a comment
There was a problem hiding this comment.
Reviewable status: 0 of 4 files reviewed, 2 unresolved discussions (waiting on @scotthart)
google/cloud/spanner/internal/status_utils.cc line 19 at r1 (raw file):
Previously, scotthart (Scott Hart) wrote…
Please use our wrapper for this header "google/cloud/internal/absl_str_cat_quiet.h"
Done.
google/cloud/spanner/testing/status_utils.cc line 17 at r1 (raw file):
Previously, scotthart (Scott Hart) wrote…
Please use our wrapper for this header "google/cloud/internal/absl_str_cat_quiet.h"
Done.
|
/gcbrun |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #14828 +/- ##
=======================================
Coverage 93.06% 93.07%
=======================================
Files 2319 2319
Lines 209023 209026 +3
=======================================
+ Hits 194535 194545 +10
+ Misses 14488 14481 -7 ☔ View full report in Codecov by Sentry. |
ProtoEnum::GetTypeName() and ProtoMessage::GetTypeName() now have the same return type as before.
evalon32
changed the title
|
We're going to wait on merging these changed until we are closer to updating our dependencies to include protobuf v30. |
scotthart
added
the
do not merge
|
/gcbrun |
|
/gcbrun |
scotthart
removed
the
do not merge
scotthart
left a comment
scotthart
left a comment
There was a problem hiding this comment.
Reviewed 2 of 4 files at r3, 2 of 2 files at r4, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @evalon32)
2 participants
Protobuf 6.30.0 will change the return types of Descriptor::name() and other methods to absl::string_view. This makes the code work both before and after such a change.
This change is