test: Adding some logging for emulator testing

test: Adding some logging for emulator testing

test: Special conditioning for emulator

test: Changes to support some tests on the emulator

chore: adding some logging for emulator

chore: try create new mux for emulator to see if tests get fixed

Author: purvavasudeo

apis/Google.Cloud.Spanner.Data/Google.Cloud.Spanner.Data.CommonTesting/SpannerTestDatabaseBase.cs

@@ -185,8 +185,10 @@ public SpannerConnection GetConnection(Logger logger, bool logCommitStats = fals
 
     public async Task<ManagedSession> GetManagedSession()
     {
-        if (_multiplexSession != null)
+        if (_multiplexSession != null && GetEnvironmentVariableOrDefault("SPANNER_EMULATOR_HOST", null) == null)
         {
+            // Only return the same multiplex session if we are NOT testing on the emulator
+            // The emulator does not handle concurrent transactions on a single multiplex session well
             return _multiplexSession;
         }
 

apis/Google.Cloud.Spanner.Data/Google.Cloud.Spanner.Data.IntegrationTests/WriteTests.cs

@@ -320,7 +320,16 @@ public async Task BadColumnName()
                 cmd.Parameters.Add("badjuju", SpannerDbType.String, IdGenerator.FromGuid());
                 var e = await Assert.ThrowsAsync<SpannerException>(() => cmd.ExecuteNonQueryAsyncWithRetry());
                 Logger.DefaultLogger.Debug($"BadColumnName: Caught error code: {e.ErrorCode}");
-                Assert.Equal(ErrorCode.NotFound, e.ErrorCode);
+                if (_fixture.RunningOnEmulator)
+                {
+                    // Emulator vs Prod give different exceptions for this case with Multiplex Sessions
+                    Assert.Equal(ErrorCode.InvalidArgument, e.ErrorCode);
+                }
+                else
+                {
+                    Assert.Equal(ErrorCode.NotFound, e.ErrorCode);
+                }
+
                 Assert.False(e.IsTransientSpannerFault());
             }
         }
@@ -348,7 +357,17 @@ public async Task BadTableName()
                 cmd.Parameters.Add("K", SpannerDbType.String, IdGenerator.FromGuid());
                 var e = await Assert.ThrowsAsync<SpannerException>(() => cmd.ExecuteNonQueryAsyncWithRetry());
                 Logger.DefaultLogger.Debug($"BadTableName: Caught error code: {e.ErrorCode}");
-                Assert.Equal(ErrorCode.NotFound, e.ErrorCode);
+
+                if(_fixture.RunningOnEmulator)
+                {
+                    // Emulator vs Prod give different exceptions for this case with Multiplex Sessions
+                    Assert.Equal(ErrorCode.InvalidArgument, e.ErrorCode);
+                }
+                else
+                {
+                    Assert.Equal(ErrorCode.NotFound, e.ErrorCode);
+                }
+   
                 Assert.False(e.IsTransientSpannerFault());
             }
         }

apis/Google.Cloud.Spanner.Data/Google.Cloud.Spanner.Data/SessionPoolManager.cs

@@ -49,7 +49,7 @@ static SessionPoolManager()
         /// is specified on construction.
         /// </summary>
         public static SessionPoolManager Default { get; } =
-            new SessionPoolManager(new SessionPoolOptions(), CreateDefaultSpannerSettings(), Logger.DefaultLogger, CreateClientAsync);
+            new SessionPoolManager(new ManagedSessionOptions(), CreateDefaultSpannerSettings(), Logger.DefaultLogger, CreateClientAsync);
 
         private readonly Func<SpannerClientCreationOptions, SpannerSettings, Task<SpannerClient>> _clientFactory;
 
@@ -161,6 +161,12 @@ internal Task<ManagedSession> AcquireManagedSessionAsync(SpannerClientCreationOp
         {
             SessionPoolSegmentKey segmentKey = SessionPoolSegmentKey.Create(dbName).WithDatabaseRole(dbRole);
             GaxPreconditions.CheckNotNull(options, nameof(options));
+            Logger.Warn($"Checking existance of mux in dictionary {segmentKey}, {_targetedMuxSessions.ContainsKey((options, segmentKey))}");
+            if(!string.IsNullOrEmpty(Environment.GetEnvironmentVariable("SPANNER_EMULATOR_HOST")) && _targetedMuxSessions.ContainsKey((options, segmentKey)))
+            {
+                _targetedMuxSessions[(options, segmentKey)] = CreateMultiplexSessionAsync();
+            }
+
             var muxSession = _targetedMuxSessions.GetOrAdd((options, segmentKey), CreateMultiplexSessionAsync());
             return muxSession;