Skip to content

Commit b9411bd

Browse files
committed
tests(Storage): Skip PAP tests.
See b/477676781. Note these were further broken in a previous attempt to fix them at #14741 and #14744
1 parent 1e08c09 commit b9411bd

File tree

2 files changed

+7
-7
lines changed

2 files changed

+7
-7
lines changed

apis/Google.Cloud.Storage.V1/Google.Cloud.Storage.V1.IntegrationTests/PublicAccessPreventionTest.cs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -24,15 +24,15 @@ public class PublicAccessPreventionTest
2424
private const string InheritedValue = "inherited";
2525
private static readonly Policy.BindingsData AllUsersViewer = new Policy.BindingsData
2626
{
27-
Members = new[] { "domain:google.com" },
27+
Members = new[] { "allUsers" },
2828
Role = "roles/storage.objectViewer"
2929
};
3030

3131
private readonly StorageFixture _fixture;
3232

3333
public PublicAccessPreventionTest(StorageFixture fixture) => _fixture = fixture;
3434

35-
[Fact]
35+
[Fact(Skip = "b/477676781")]
3636
public void PreventAccessOnExistingBucket()
3737
{
3838
var client = _fixture.Client;
@@ -51,7 +51,7 @@ public void PreventAccessOnExistingBucket()
5151
Assert.Throws<GoogleApiException>(() => client.SetBucketIamPolicy(bucketName, policy));
5252
}
5353

54-
[Fact]
54+
[Fact(Skip = "b/477676781")]
5555
public void PreventAccessOnNewBucket()
5656
{
5757
var client = _fixture.Client;
@@ -70,7 +70,7 @@ public void PreventAccessOnNewBucket()
7070
Assert.Throws<GoogleApiException>(() => client.SetBucketIamPolicy(bucketName, policy));
7171
}
7272

73-
[Fact]
73+
[Fact(Skip = "b/477676781")]
7474
public void RestoreAccess()
7575
{
7676
var client = _fixture.Client;

apis/Google.Cloud.Storage.V1/Google.Cloud.Storage.V1.Snippets/StorageClientSnippets.cs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -632,7 +632,7 @@ public void GetBucketIamPolicy()
632632
// See [GetBucketIamPolicy](ref) for a synchronous example.
633633
// End see-also
634634

635-
[Fact]
635+
[Fact(Skip = "b/477676781")]
636636
public async Task SetBucketIamPolicy()
637637
{
638638
var projectId = _fixture.ProjectId;
@@ -651,7 +651,7 @@ public async Task SetBucketIamPolicy()
651651
Console.WriteLine($"Response code before setting policy: {response1.StatusCode}");
652652

653653
// Fetch the current IAM policy, and modify it in memory to allow all users
654-
// of a certain domain to view objects.
654+
// to view objects.
655655
Policy policy = client.GetBucketIamPolicy(bucketName);
656656
string role = "roles/storage.objectViewer";
657657
Policy.BindingsData binding = policy.Bindings
@@ -662,7 +662,7 @@ public async Task SetBucketIamPolicy()
662662
binding = new Policy.BindingsData { Role = role, Members = new List<string>() };
663663
policy.Bindings.Add(binding);
664664
}
665-
binding.Members.Add("domain:google.com");
665+
binding.Members.Add("allUsers");
666666

667667
// Update the IAM policy on the bucket.
668668
client.SetBucketIamPolicy(bucketName, policy);

0 commit comments

Comments
 (0)