feat: Add Spanner request ID header

Author: robertvoinescu-work

apis/Google.Cloud.Spanner.V1/Google.Cloud.Spanner.V1.Tests/RequestIdTests.cs

@@ -0,0 +1,239 @@
+// Copyright 2024 Google LLC
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//     https://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+using Grpc.Core;
+using Google.Api.Gax.Grpc;
+using System;
+using System.Linq;
+using System.Threading.Tasks;
+using Xunit;
+using System.Collections.Generic;
+
+namespace Google.Cloud.Spanner.V1.Tests;
+
+public class RequestIdTests
+{
+    private const string SampleDatabaseName = "projects/proj/instances/inst/databases/db";
+    private const string SampleSessionName = "projects/proj/instances/inst/databases/db/sessions/sess";
+
+    [Fact]
+    public void RequestId_Format()
+    {
+        var expectedProcessId = "processId";
+        var expectedClientId = 123;
+        var expectedRequestSequence = 456;
+        var requestId = new RequestId(expectedProcessId, expectedClientId, expectedRequestSequence);
+
+        // The expected format is 6 parts that break down as such:
+        // {VersionId}.{s_processId}.{ClientId}.{ChannelId}.{RequestSequence}.{AttemptNum}
+        var idString = requestId.IncrementAttempt().ToString();
+        var parts = idString.Split('.');
+
+        Assert.Equal(6, parts.Length);
+        var versionId = parts[0];
+        var processId = parts[1];
+        var clientId = parts[2];
+        var channelId = parts[3];
+        var requestSequence = parts[4];
+        var attemptNum = parts[5];
+
+        Assert.Equal("1", versionId);
+        Assert.Equal(expectedClientId.ToString(), clientId);
+        Assert.Equal("1", channelId);
+        Assert.Equal(expectedRequestSequence.ToString(), requestSequence);
+        Assert.Equal("1", attemptNum);
+        Assert.Equal(expectedProcessId, processId);
+    }
+
+    [Fact]
+    public void RequestId_IncrementAttemptNum()
+    {
+        var requestId = new RequestId("processId", 1, 1);
+        for (int expectedAttemptNum = 1; expectedAttemptNum < 5; expectedAttemptNum++)
+        {
+            var parts = requestId.IncrementAttempt().ToString().Split('.');
+            Assert.Equal(6, parts.Length);
+            var actualAttemptNum = parts[5];
+            Assert.Equal($"{expectedAttemptNum}", actualAttemptNum);
+        }
+    }
+
+    [Fact]
+    public void RequestIdSource_ProcessId_OverwritingBehavior()
+    {
+        // Capture the initial ProcessId. This could be the default generated ID,
+        // or a value set by another test if XUnit's test execution order leads to state leakage.
+        var initialProcessId = RequestIdSource.ProcessId;
+
+        // Try to set the ProcessId to "first_override".
+        // This will only succeed if ProcessId has not been accessed/initialized yet.
+        RequestIdSource.ProcessId = "first_override";
+
+        // After attempting to set, retrieve the current ProcessId.
+        var currentProcessId = RequestIdSource.ProcessId;
+
+        // If ProcessId was initially the default and we successfully set it to "first_override",
+        // then currentProcessId should be "first_override".
+        // Otherwise, it means ProcessId was already created (either by default or another test),
+        // and our attempt to set it was ignored. In this case, currentProcessId should equal initialProcessId.
+        string expectedProcessIdAfterFirstAttempt = initialProcessId == currentProcessId ? initialProcessId : "first_override";
+        Assert.Equal(expectedProcessIdAfterFirstAttempt, currentProcessId);
+
+        // Now, attempt to set it a second time. This should always be ignored if already initialized.
+        RequestIdSource.ProcessId = "second_override";
+
+        // Verify that the ProcessId has not changed from its state after the first attempt.
+        Assert.Equal(expectedProcessIdAfterFirstAttempt, RequestIdSource.ProcessId);
+    }
+
+    // Tests for header injection
+    public static TheoryData<Action<SpannerClient>> SpannerClientActions { get; } = new TheoryData<Action<SpannerClient>>
+    {
+        client => client.CreateSession(new CreateSessionRequest { Database = SampleDatabaseName }),
+        client => client.BatchCreateSessions(new BatchCreateSessionsRequest { Database = SampleDatabaseName }),
+        client => client.GetSession(new GetSessionRequest { Name = SampleSessionName }),
+        client => client.ListSessions(new ListSessionsRequest { Database = SampleDatabaseName }).AsRawResponses().First(),
+        client => client.DeleteSession(new DeleteSessionRequest { Name = SampleSessionName }),
+        client => client.ExecuteSql(new ExecuteSqlRequest { Session = SampleSessionName }),
+        client => client.ExecuteBatchDml(new ExecuteBatchDmlRequest { Session = SampleSessionName }),
+        client => client.Read(new ReadRequest { Session = SampleSessionName }),
+        client => client.BeginTransaction(new BeginTransactionRequest { Session = SampleSessionName }),
+        client => client.Commit(new CommitRequest { Session = SampleSessionName }),
+        client => client.Rollback(new RollbackRequest { Session = SampleSessionName }),
+        client => client.PartitionQuery(new PartitionQueryRequest { Session = SampleSessionName }),
+        client => client.PartitionRead(new PartitionReadRequest { Session = SampleSessionName })
+    };
+
+    [Theory]
+    [MemberData(nameof(SpannerClientActions))]
+    public void SetsHeaderOnRpcCalls(Action<SpannerClient> action)
+    {
+        var invoker = new RetryFakeCallInvoker();
+        var client = new SpannerClientBuilder { CallInvoker = invoker }.Build();
+        action(client);
+        Metadata.Entry entry = Assert.Single(invoker.CapturedMetadata[0], e => e.Key == RequestId.HeaderKey);
+        Assert.NotNull(entry.Value);
+    }
+
+    [Fact]
+    public void IncrementsRequestIdOnRetry()
+    {
+        var invoker = new RetryFakeCallInvoker(failCount: 1);
+        var settings = new SpannerSettings
+        {
+            // Configure the CreateSession call to retry on Unavailable errors.
+            CallSettings = CallSettings.FromRetry(RetrySettings.FromExponentialBackoff(
+                maxAttempts: 3,
+                initialBackoff: TimeSpan.FromMilliseconds(1),
+                maxBackoff: TimeSpan.FromMilliseconds(1),
+                backoffMultiplier: 1.0,
+                retryFilter: RetrySettings.FilterForStatusCodes(StatusCode.Unavailable)))
+        };
+        var client = new SpannerClientBuilder { CallInvoker = invoker, Settings = settings }.Build();
+
+        client.CreateSession(new CreateSessionRequest { Database = SampleDatabaseName });
+        client.CreateSession(new CreateSessionRequest { Database = SampleDatabaseName });
+        client.CreateSession(new CreateSessionRequest { Database = SampleDatabaseName });
+
+        // Assert that the invoker was called four times for the three client calls.
+        // The first call should have failed the first time and succeeded on retry.
+        Assert.Equal(4, invoker.CapturedMetadata.Count);
+
+        var requestIds = invoker.CapturedMetadata
+            .Select(m => m.Single(e => e.Key == RequestId.HeaderKey).Value)
+            .Select(id => new SpannerRequestIdParts(id))
+            .ToList();
+
+        Assert.Equal((1, 1), (requestIds[0].RequestSequence, requestIds[0].AttemptNum));
+        Assert.Equal((1, 2), (requestIds[1].RequestSequence, requestIds[1].AttemptNum));
+        Assert.Equal((2, 1), (requestIds[2].RequestSequence, requestIds[2].AttemptNum));
+        Assert.Equal((3, 1), (requestIds[3].RequestSequence, requestIds[3].AttemptNum));
+    }
+
+    /// <summary>
+    /// A fake call invoker that fails the first time it's called with an "Unavailable" status,
+    /// and succeeds on subsequent calls. It captures the metadata for every call.
+    /// </summary>
+    private class RetryFakeCallInvoker : CallInvoker
+    {
+        private int _callCount = 0;
+        private readonly int _failCount;
+        public List<Metadata> CapturedMetadata { get; } = new List<Metadata>();
+
+        public RetryFakeCallInvoker(int failCount = 0) => _failCount = failCount;
+
+        public override TResponse BlockingUnaryCall<TRequest, TResponse>(Method<TRequest, TResponse> method, string host, CallOptions options, TRequest request)
+        {
+            CapturedMetadata.Add(options.Headers);
+            _callCount++;
+
+            if (_callCount <= _failCount)
+            {
+                // Fail the first time with a retryable error.
+                throw new RpcException(new Status(StatusCode.Unavailable, "Transient error"));
+            }
+
+            // Succeed on the second attempt.
+            return (TResponse)Activator.CreateInstance(typeof(TResponse));
+        }
+
+        public override AsyncClientStreamingCall<TRequest, TResponse> AsyncClientStreamingCall<TRequest, TResponse>(Method<TRequest, TResponse> method, string host, CallOptions options) =>
+            throw new NotImplementedException();
+
+        public override AsyncDuplexStreamingCall<TRequest, TResponse> AsyncDuplexStreamingCall<TRequest, TResponse>(Method<TRequest, TResponse> method, string host, CallOptions options) =>
+            throw new NotImplementedException();
+
+        public override AsyncServerStreamingCall<TResponse> AsyncServerStreamingCall<TRequest, TResponse>(Method<TRequest, TResponse> method, string host, CallOptions options, TRequest request) =>
+            throw new NotImplementedException();
+
+        public override AsyncUnaryCall<TResponse> AsyncUnaryCall<TRequest, TResponse>(Method<TRequest, TResponse> method, string host, CallOptions options, TRequest request)
+        {
+            CapturedMetadata.Add(options.Headers);
+            _callCount++;
+
+            if (_callCount <= _failCount)
+            {
+                // Fail the first time with a retryable error.
+                throw new RpcException(new Status(StatusCode.Unavailable, "Transient error"));
+            }
+
+            // Succeed on the second attempt.
+            var response = (TResponse)Activator.CreateInstance(typeof(TResponse));
+            return new AsyncUnaryCall<TResponse>(Task.FromResult(response), Task.FromResult(new Metadata()), () => Status.DefaultSuccess, () => new Metadata(), () => { });
+        }
+    }
+
+    private struct SpannerRequestIdParts
+    {
+        public int VersionId { get; }
+        public ulong ProcessId { get; }
+        public int ClientId { get; }
+        public int ChannelId { get; }
+        public int RequestSequence { get; }
+        public int AttemptNum { get; }
+
+        public SpannerRequestIdParts(string requestId)
+        {
+            var parts = requestId.Split('.');
+            Assert.Equal(6, parts.Length);
+
+            VersionId = int.Parse(parts[0]);
+            ProcessId = ulong.Parse(parts[1]);
+            ClientId = int.Parse(parts[2]);
+            ChannelId = int.Parse(parts[3]);
+            RequestSequence = int.Parse(parts[4]);
+            AttemptNum = int.Parse(parts[5]);
+        }
+    }
+}

apis/Google.Cloud.Spanner.V1/Google.Cloud.Spanner.V1/RequestId.cs

@@ -0,0 +1,91 @@
+// Copyright 2025 Google LLC
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//     https://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+namespace Google.Cloud.Spanner.V1;
+
+/// <summary>
+/// Represents a structured request ID for Spanner RPCs, formatted as:
+/// {version}.{process}.{client}.{channel}.{request}.{attempt}
+/// </summary>
+internal sealed class RequestId
+{
+    /// <summary>
+    /// The header key used for Spanner request IDs.
+    /// </summary>
+    internal const string HeaderKey = "x-goog-spanner-request-id";
+
+
+    /// <summary>
+    /// The version number of the request ID format.
+    /// </summary>
+    private const int FormatVersion = 1;
+
+    /// <summary>
+    /// A unique ID for the user application process. This can be overridden, but only before it has been accessed.
+    /// </summary>
+    private readonly string _processId;
+
+    /// <summary>
+    /// A unique ID for the gRPC channel being used. This is hardcoded to 1 for now.
+    /// See: b/459445539
+    /// </summary>
+    private readonly int _channelId  = 1;
+
+    /// <summary>
+    /// A unique ID for the <see cref="SpannerClient"/> instance that generated the request.
+    /// </summary>
+    private readonly int _clientId;
+
+    /// <summary>
+    /// A unique ID for the logical request made using the current <see cref="SpannerClient"/>.
+    /// </summary>
+    private readonly int _requestId;
+
+    /// <summary>
+    /// A unique ID for each attempt of the request, incremented before each RPC attempt.
+    /// </summary>
+    private int _attemptId = 0;
+
+    /// <summary>
+    /// Initializes a new instance of the <see cref="RequestId"/> class
+    /// with a specified client and logical request identifier.
+    /// </summary>
+    /// <param name="clientId">The ID for the <see cref="SpannerClient"/> associated with the request.</param>
+    /// <param name="processId">The ID for the user application process.</param>
+    /// <param name="requestId">The ID of the logical request within the client.</param>
+    internal RequestId(string processId, int clientId, int requestId)
+    {
+        _processId = processId;
+        _clientId = clientId;
+        _requestId = requestId;
+    }
+
+    /// <summary>
+    /// Increments the request's attempt number and then returns the request ID.
+    /// </summary>
+    internal RequestId IncrementAttempt()
+    {
+        // Retry attempts are expected to be sequential so we can safely
+        // increment without first acquiring a lock.
+        _attemptId++;
+        return this;
+    }
+
+    /// <summary>
+    /// Returns the string representation of the Spanner request ID.
+    /// </summary>
+    public override string ToString() => $"{FormatVersion}.{_processId}.{_clientId}.{_channelId}.{_requestId}.{_attemptId}";
+
+}