Skip to content

Commit 506e3ef

Browse files
authored
fix: add per-service apiVersion to gapic_metadata (#788)
1 parent e12d281 commit 506e3ef

File tree

4 files changed

+8
-0
lines changed

4 files changed

+8
-0
lines changed

generator/gapic-generator-typescript/baselines/showcase-esm/esm/src/v1beta1/gapic_metadata.json.baseline

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -120,6 +120,7 @@
120120
}
121121
},
122122
"Echo": {
123+
"apiVersion": "v1_20240408",
123124
"clients": {
124125
"grpc": {
125126
"libraryClient": "EchoClient",

generator/gapic-generator-typescript/baselines/showcase/src/v1beta1/gapic_metadata.json.baseline

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -120,6 +120,7 @@
120120
}
121121
},
122122
"Echo": {
123+
"apiVersion": "v1_20240408",
123124
"clients": {
124125
"grpc": {
125126
"libraryClient": "EchoClient",

generator/gapic-generator-typescript/templates/cjs/typescript_gapic_metadata/src/$version/gapic_metadata.json.njk

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -43,6 +43,9 @@ limitations under the License.
4343
{%- for service in api.services -%}
4444
{{- serviceJoiner() -}}
4545
"{{ service.name }}": {
46+
{%- if service.apiVersion -%}
47+
"apiVersion": "{{ service.apiVersion }}",
48+
{%- endif -%}
4649
{#- TODO(@alexander-fenster): replace hardcoded transports ("grpc", etc.) with an iteration. -#}
4750
"clients": {
4851
"grpc": {

generator/gapic-generator-typescript/templates/esm/typescript_gapic_metadata/esm/src/$version/gapic_metadata.json.njk

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -43,6 +43,9 @@ limitations under the License.
4343
{%- for service in api.services -%}
4444
{{- serviceJoiner() -}}
4545
"{{ service.name }}": {
46+
{%- if service.apiVersion -%}
47+
"apiVersion": "{{ service.apiVersion }}",
48+
{%- endif -%}
4649
{#- TODO(@alexander-fenster): replace hardcoded transports ("grpc", etc.) with an iteration. -#}
4750
"clients": {
4851
"grpc": {

0 commit comments

Comments
 (0)