Skip to content

Commit 7785efe

Browse files
chore: remove workspaces (#137)
* feat: remove workspaces configuration * fix: remove preinstall-deps command from github actions * fix: add required permissions in run_condtional_lint and run_on_changed * fix: tsconfig extends path
1 parent 82e8401 commit 7785efe

File tree

4 files changed

+15
-57
lines changed

4 files changed

+15
-57
lines changed

.github/workflows/continuous.yaml

Lines changed: 8 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -16,45 +16,34 @@ jobs:
1616
with:
1717
version: ^10.0.0
1818
- run: node --version
19-
- run: npm run preinstall-deps
2019
- run: ci/run_conditional_tests.sh
2120
name: Run unit tests
2221
env:
2322
BUILD_TYPE: continuous
2423
TEST_TYPE: units
25-
- run: npm i && npm test
2624
windows:
2725
runs-on: windows-latest
2826
steps:
2927
- uses: actions/checkout@v5
3028
- uses: actions/setup-node@v4
3129
with:
3230
node-version: 18
33-
- run: npm run preinstall-deps
34-
- run: npm install --engine-strict
35-
- run: npm test
31+
- run: node --version
32+
- run: ci/run_conditional_tests.sh
3633
env:
3734
MOCHA_THROW_DEPRECATION: false
3835
lint:
3936
runs-on: ubuntu-latest
4037
steps:
4138
- uses: actions/checkout@v5
42-
- uses: actions/setup-node@v4
4339
with:
44-
node-version: 18
45-
- run: npm run preinstall-deps
46-
- run: npm install
47-
- run: npm run lint
48-
docs:
49-
runs-on: ubuntu-latest
50-
steps:
51-
- uses: actions/checkout@v5
40+
fetch-depth: 300 # Fetch all history for comparison
5241
- uses: actions/setup-node@v4
5342
with:
5443
node-version: 18
55-
- run: npm run preinstall-deps
5644
- run: npm install
57-
- run: npm run docs
58-
- uses: JustinBeckwith/linkinator-action@v1
59-
with:
60-
paths: docs/
45+
- run: ci/run_conditional_tests.sh
46+
name: Run lint
47+
env:
48+
BUILD_TYPE: continuous
49+
TEST_TYPE: lint

.github/workflows/presubmit.yaml

Lines changed: 6 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@ jobs:
1515
with:
1616
version: ^10.0.0
1717
- run: node --version
18-
- run: npm run preinstall-deps
1918
- run: npm i && ci/run_conditional_tests.sh
2019
name: Run unit tests
2120
env:
@@ -25,22 +24,13 @@ jobs:
2524
runs-on: ubuntu-latest
2625
steps:
2726
- uses: actions/checkout@v5
28-
- uses: actions/setup-node@v4
2927
with:
30-
node-version: 18
31-
- run: npm run preinstall-deps
32-
- run: npm install
33-
- run: npm run lint
34-
docs:
35-
runs-on: ubuntu-latest
36-
steps:
37-
- uses: actions/checkout@v5
28+
fetch-depth: 300 # Fetch all history for comparison
3829
- uses: actions/setup-node@v4
3930
with:
4031
node-version: 18
41-
- run: npm run preinstall-deps
42-
- run: npm install
43-
- run: npm run docs
44-
- uses: JustinBeckwith/linkinator-action@v1
45-
with:
46-
paths: docs/
32+
- run: npm i && ci/run_conditional_tests.sh
33+
name: Run lint
34+
env:
35+
BUILD_TYPE: presubmit
36+
TEST_TYPE: lint

package.json

Lines changed: 0 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -14,26 +14,5 @@
1414
},
1515
"bugs": {
1616
"url": "https://github.com/googleapis/google-cloud-node-core/issues"
17-
},
18-
"scripts": {
19-
"preinstall-deps": "./bin/install-deps.sh",
20-
"test": "npm test --ws",
21-
"samples-test": "npm run samples-test --ws",
22-
"system-test": "npm run system-test --ws",
23-
"prelint": "npm run prelint --ws",
24-
"lint": "npm run lint --ws",
25-
"fix": "npm run fix --ws",
26-
"docs": "npm run docs --ws"
27-
},
28-
"workspaces": [
29-
"dev-packages/*",
30-
"packages/*"
31-
],
32-
"dependencies": {
33-
"gaxios": "^7.1.2",
34-
"gcp-metadata": "^8.1.1",
35-
"jsdoc-fresh": "^5.0.2",
36-
"jsdoc-region-tag": "^4.0.1",
37-
"pack-n-play": "^4.2.1"
3817
}
3918
}

packages/gcp-metadata/tsconfig.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
{
2-
"extends": "./../../node_modules/gts/tsconfig-google.json",
2+
"extends": "./node_modules/gts/tsconfig-google.json",
33
"compilerOptions": {
44
"lib": ["ES2023", "dom"],
55
"module": "nodenext",

0 commit comments

Comments
 (0)