retries not working with gaxioserror in gaxios v7 #173
Description
Please make sure you have searched for information in the following guides.
- Search the issues already opened: https://github.com/GoogleCloudPlatform/google-cloud-node/issues
- Search StackOverflow: http://stackoverflow.com/questions/tagged/google-cloud-platform+node.js
- Check our Troubleshooting guide: https://github.com/googleapis/google-cloud-node/blob/main/docs/troubleshooting.md
- Check our FAQ: https://github.com/googleapis/google-cloud-node/blob/main/docs/faq.md
- Check our libraries HOW-TO: https://github.com/googleapis/gax-nodejs/blob/main/client-libraries.md
- Check out our authentication guide: https://github.com/googleapis/google-auth-library-nodejs
- Check out handwritten samples for many of our APIs: https://github.com/GoogleCloudPlatform/nodejs-docs-samples
Link to the code that reproduces this issue. A link to a public Github Repository or gist with a minimal reproduction.
No response
A step-by-step description of how to reproduce the issue, based on the linked reproduction.
n/a
A clear and concise description of what the bug is, and what you expected to happen.
googleapis/gaxios#699 made GaxiosError AIP-193 compiliant. With that change GaxiosError.code returns the http status code instead of the grpc error code. Gax retry logic is using grpc status codes from client config to determine when to retry. Retries therefore will not be attempted when expected because the grpc status codes and returned http status codes do not match. Gax could attempt to parse GaxiosError.message to get the underlying API error(s) and then extract the grpc error codes.
A clear and concise description WHY you expect this behavior, i.e., was it a recent change, there is documentation that points to this behavior, etc. **
n/a