Selective gapic generation is broken

[sofisl]

I think the selective gapic generation isn't quite working, and in order to confirm we should add a full test that reads from an actual service config file, like this in this PR. @danieljbruce and I were trying out selective gapic with bigtable admin, and we attempted to generate a new library with this file. The outcome of the generation was that only a single method was listed internal, RestoreTableMetadata. This seems wrong since we listed a bunch of methods to be internal, but I also am not very familiar with the logic behind what gets generated or not.

Also, we had to change the settings property from node_settings to typescript_settings to get anything to produce, which is not how the service_yaml file is set up (it should be node_settings). I think this is a bug in the generator implementation.

[kevkim-codes]

Could you give me some reproducible steps? What did the config look like and which methods were you trying to mark as internal?

[kevkim-codes]

The typescript_settings is actually correct according to the selective gapic design doc. But this might mean we need better documentation for dev usage.

[sofisl]

I saw that! But I think everywhere else in our libraries we use node_settings (take a look at publishing files like this one, all of the ones I saw in googleapis used node_settings.

I linked the yaml file we used above in a gpaste (we're attempting to modify the existing one)

We generated the library this way (for google/bigtable/admin/v2/)

bazelisk run //:gapic_generator_typescript --    --output-dir "$OUTPUT_DIR_NAME"    -I "$GOOGLEAPIS"    --grpc-service-config "$GOOGLEAPIS/$PROTO_PATH/$GRPC_NAME"    --service-yaml "$GOOGLEAPIS/$PROTO_PATH/$SERVICE_YAML"    `find "$GOOGLEAPIS/$PROTO_PATH" -name '*.proto'`    "$GOOGLEAPIS/google/cloud/common_resources.proto"^C

[kevkim-codes]

Hmm okay yeah we can make the change to node_settings fairly easily so I can change that. Let me try to reproduce the issue and then go from there. Have also been talking with @danieljbruce offline.

[kevkim-codes]

Okay - so I used the same service yaml, but used a vanilla bazel command (I was having trouble with bazelisk before).

Minus the node_settings discrepancy, the admin client generates with all the internal methods properly. Here's a gpaste.

[kevkim-codes]

As a follow up for this issue (in the below order):

1. I will update the parsing in generator for the service yaml to look for node_settings
2. I will create a PR for testing in the showcase yaml.
3. Figure out what's missing in the README for devs re: selective gapic.

[kevkim-codes]

Okay sorry for the barrage of comments, but one last realization is that the original yaml you linked is missing as_deny_list: true. You should get the expected output with that flag on.

[kevkim-codes]

1. is complete: fix: Change typescript_settings to node_settings gapic-generator-typescript#1810

As a follow up for this issue (in the below order):

1. I will update the parsing in generator for the service yaml to look for node_settings
2. I will create a PR for testing in the showcase yaml.
3. Figure out what's missing in the README for devs re: selective gapic.