-
Notifications
You must be signed in to change notification settings - Fork 11
Closed
googleapis/nodejs-googleapis-common
#492Labels
priority: p2Moderately-important priority. Fix may not be included in next release.Moderately-important priority. Fix may not be included in next release.type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Description
-
Is this a client library issue or a product issue?
Client library issue -
Did someone already solve this?
No -
Do you have a support contract?
No
Environment details
- OS: MacOs 12.5.1
- Node.js version: 16.16.0 LTS
- npm version: 8.14.0
googleapis-commonversion: 6.0.1
Steps to reproduce
- Set Gmail API options to use http2 request
- Call
gmailApi.users.threads.modifywith valid parameters. - Observe app being
#deadlocked - Notice query parameter
removeLabelIds[]=...instead ofremoveLabelIds=...&removeLabelIds=...
Solution proposals
Solution to deadlock is to change this lines into
if (config.data) {
if (config.data instanceof stream_1.Stream) {
config.data.pipe(req);
}
else if (typeof config.data === 'string') {
const data = Buffer.from(config.data);
req.write(data);
}
else if (typeof config.data === 'object') {
const data = JSON.stringify(config.data);
req.write(data);
}
}
req.end();
Solution for wrong queryParameters serialization is to change this line into const q = opts.paramsSerializer(opts.params);
Metadata
Metadata
Assignees
Labels
priority: p2Moderately-important priority. Fix may not be included in next release.Moderately-important priority. Fix may not be included in next release.type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.Error or flaw in code with unintended results or allowing sub-optimal usage patterns.