ensure instance state is always int

Author: bshaffer

Spanner/src/Instance.php

@@ -332,16 +332,13 @@ public function create(InstanceConfiguration $config, array $options = []): Long
      * ```
      *
      * @param array $options [optional] Configuration options.
-     * @return int|null
+     * @return int
      */
-    public function state(array $options = []): int|null
+    public function state(array $options = []): int
     {
         $info = $this->info($options);
 
-        // @TODO investigate why state is now 0 but in v1 it was unset
-        return (isset($info['state']) && $info['state'] !== 0)
-            ? $info['state']
-            : null;
+        return $info['state'] ?? State::STATE_UNSPECIFIED;
     }
 
     /**

Spanner/tests/Unit/InstanceTest.php

@@ -26,6 +26,7 @@
 use Google\Cloud\Core\Testing\GrpcTestTrait;
 use Google\Cloud\Core\LongRunning\LongRunningOperation;
 use Google\Cloud\Spanner\Admin\Database\V1\Backup as BackupProto;
+use Google\Cloud\Spanner\Admin\Database\V1\Backup\State;
 use Google\Cloud\Spanner\Admin\Database\V1\Client\DatabaseAdminClient;
 use Google\Cloud\Spanner\Admin\Database\V1\Database as DatabaseProto;
 use Google\Cloud\Spanner\Admin\Database\V1\ListBackupOperationsResponse;
@@ -264,7 +265,7 @@ public function testState()
         $this->assertEquals(Instance::STATE_READY, $this->instance->state());
     }
 
-    public function testStateIsNull()
+    public function testStateIsUnspecified()
     {
         $this->instanceAdminClient->getInstance(
             Argument::that(function ($request) {
@@ -277,7 +278,7 @@ public function testStateIsNull()
             ->shouldBeCalledOnce()
             ->willReturn(new InstanceProto());
 
-        $this->assertNull($this->instance->state());
+        $this->assertEquals(State::STATE_UNSPECIFIED, $this->instance->state());
     }
 
     public function testUpdate()