Skip to content

Commit c2bb1c3

Browse files
committed
revert eventarc and .github changes, fix package tests
1 parent 4cac6cf commit c2bb1c3

File tree

3 files changed

+10
-12
lines changed

3 files changed

+10
-12
lines changed

.github/run-package-tests.sh

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -15,11 +15,7 @@
1515

1616
set -e
1717

18-
if [ "$#" -gt 0 ]; then
19-
DIRS=$1
20-
else
21-
DIRS=$(find * -maxdepth 0 -type d -name '[A-Z]*')
22-
fi
18+
DIRS=$(find * -maxdepth 0 -type d -name '[A-Z]*')
2319

2420
PREFER_LOWEST=""
2521
if [ "$#" -eq 1 ]; then

EventarcPublishing/src/V1/Client/PublisherClient.php

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -104,9 +104,7 @@ final class PublisherClient
104104
private const CODEGEN_NAME = 'gapic';
105105

106106
/** The default scopes required by the service. */
107-
public static $serviceScopes = [
108-
'https://www.googleapis.com/auth/cloud-platform',
109-
];
107+
public static $serviceScopes = ['https://www.googleapis.com/auth/cloud-platform'];
110108

111109
private static function getClientDefaults()
112110
{
@@ -260,8 +258,10 @@ public function publish(PublishRequest $request, array $callOptions = []): Publi
260258
*
261259
* @throws ApiException Thrown if the API call fails.
262260
*/
263-
public function publishChannelConnectionEvents(PublishChannelConnectionEventsRequest $request, array $callOptions = []): PublishChannelConnectionEventsResponse
264-
{
261+
public function publishChannelConnectionEvents(
262+
PublishChannelConnectionEventsRequest $request,
263+
array $callOptions = []
264+
): PublishChannelConnectionEventsResponse {
265265
return $this->startApiCall('PublishChannelConnectionEvents', $request, $callOptions)->wait();
266266
}
267267

Spanner/tests/Unit/SpannerClientTest.php

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -542,7 +542,8 @@ public function testClientPassesIsolationLevel()
542542
$client = new SpannerClient([
543543
'projectId' => self::PROJECT,
544544
'directedReadOptions' => $this->directedReadOptionsIncludeReplicas,
545-
'isolationLevel' => IsolationLevel::REPEATABLE_READ
545+
'isolationLevel' => IsolationLevel::REPEATABLE_READ,
546+
'credentials' => Fixtures::KEYFILE_STUB_FIXTURE(),
546547
]);
547548

548549
$reflectedClient = new ReflectionClass($client);
@@ -578,7 +579,8 @@ public function testTransactionHasCorrectIsolationLevel()
578579
$client = new SpannerClient([
579580
'projectId' => self::PROJECT,
580581
'directedReadOptions' => $this->directedReadOptionsIncludeReplicas,
581-
'isolationLevel' => IsolationLevel::REPEATABLE_READ
582+
'isolationLevel' => IsolationLevel::REPEATABLE_READ,
583+
'credentials' => Fixtures::KEYFILE_STUB_FIXTURE(),
582584
]);
583585

584586
$reflectedClient = new ReflectionClass($client);

0 commit comments

Comments
 (0)