Merge branch 'spanner-v2-refactor' of github.com:googleapis/google-cloud-php into spanner-v2-refactor

Author: bshaffer

Spanner/src/Operation.php

@@ -877,7 +877,8 @@ public function partitionRead(
      * @see https://cloud.google.com/spanner/reference/rpc/google.spanner.v1#google.spanner.v1.BeginTransactionRequest BeginTransactionRequest
      *
      * @param Session $session The session to start the snapshot in.
-     * @param array $options [optional] Configuration options.
+     * @param BeginTransactionRequest $beginTransaction
+     * @param array $callOptions
      *
      * @return array
      */
@@ -1083,7 +1084,9 @@ private function formatTransactionOptions(array $transactionOptions): array
     }
 
     /**
-     * @param array $args
+     * @param string $databaseName
+     * @param ExecuteSqlRequest $executeSqlRequest
+     * @param array $callOptions
      * @return \Generator
      */
     private function executeStreamingSql(string $databaseName, ExecuteSqlRequest $executeSqlRequest, array $callOptions): \Generator
@@ -1100,7 +1103,9 @@ private function executeStreamingSql(string $databaseName, ExecuteSqlRequest $ex
     }
 
     /**
-     * @param array $args
+     * @param string $databaseName
+     * @param ReadRequest $readRequest
+     * @param array $callOptions
      * @return \Generator
      */
     private function streamingRead(string $databaseName, ReadRequest $readRequest, array $callOptions): \Generator

Spanner/src/TransactionConfigurationTrait.php

@@ -102,7 +102,10 @@ private function transactionOptions(array &$options, ?PBReadOnly $transactionLev
             $transactionOptions = $id;
         } elseif ($context === SessionPoolInterface::CONTEXT_READ) {
             $options += ['singleUse' => null];
-            $transactionOptions = $this->configureReadOnlyTransactionOptions($options, $transactionLevelReadOnlyOptions);
+            $transactionOptions = $this->configureReadOnlyTransactionOptions(
+                $options,
+                $transactionLevelReadOnlyOptions
+            );
         } elseif ($context === SessionPoolInterface::CONTEXT_READWRITE) {
             $transactionOptions = $this->configureReadWriteTransactionOptions(
                 // TODO: Find out when $begin is a bool and fix it
@@ -189,8 +192,10 @@ private function configureReadWriteTransactionOptions(array|TransactionOptions $
      * @param PBReadOnly $transactionLevelReadOnlyOptions Previously given call options (for single-use snapshots).
      * @return array
      */
-    private function configureReadOnlyTransactionOptions(array $options, ?PBReadOnly $transactionLevelReadOnlyOptions = null): array
-    {
+    private function configureReadOnlyTransactionOptions(
+        array $options,
+        ?PBReadOnly $transactionLevelReadOnlyOptions = null
+    ): array {
         // select only the PBReadOnly fields from $options
         $readOnly = array_intersect_key($options, array_flip([
             'minReadTimestamp',