address feedback

Author: ohmayr

.generator/cli.py

@@ -1096,7 +1096,23 @@ def _update_version_for_library(
     # Find and update version.py or gapic_version.py files
     search_base = Path(f"{repo}/{path_to_library}")
     version_files = list(search_base.rglob("**/gapic_version.py"))
-    version_files.extend(list(search_base.glob("google/**/version.py")))
+    excluded_dirs = {
+        ".nox",
+        ".venv",
+        "venv",
+        "site-packages",
+        ".git",
+        "build",
+        "dist",
+        "__pycache__",
+    }
+    version_files.extend(
+        [
+            p
+            for p in search_base.rglob("**/version.py")
+            if not any(part in excluded_dirs for part in p.parts)
+        ]
+    )
 
     if not version_files:
         # Fallback to `pyproject.toml`` or `setup.py``. Proto-only libraries have

.generator/test_cli.py

@@ -986,9 +986,12 @@ def test_update_global_changelog(mocker, mock_release_init_request_file):
 def test_update_version_for_library_success_gapic(mocker):
     m = mock_open()
 
-    mock_rglob = mocker.patch(
-        "pathlib.Path.rglob", return_value=[pathlib.Path("repo/gapic_version.py")]
-    )
+    mock_rglob = mocker.patch("pathlib.Path.rglob")
+    mock_rglob.side_effect = [
+        [pathlib.Path("repo/gapic_version.py")],                  # 1st call (gapic_version.py)
+        [],                                                       # 2nd call (version.py)
+        [pathlib.Path("repo/samples/snippet_metadata.json")]      # 3rd call (snippets)
+    ]
     mock_shutil_copy = mocker.patch("shutil.copy")
     mock_content = '__version__ = "1.2.2"'
     mock_json_metadata = {"clientLibrary": {"version": "0.1.0"}}
@@ -1018,7 +1021,11 @@ def test_update_version_for_library_success_proto_only_setup_py(mocker):
     m = mock_open()
 
     mock_rglob = mocker.patch("pathlib.Path.rglob")
-    mock_rglob.side_effect = [[], [pathlib.Path("repo/setup.py")]]
+    mock_rglob.side_effect = [
+        [],
+        [pathlib.Path("repo/setup.py")],
+        [pathlib.Path("repo/samples/snippet_metadata.json")]
+    ]
     mock_shutil_copy = mocker.patch("shutil.copy")
     mock_content = 'version = "1.2.2"'
     mock_json_metadata = {"clientLibrary": {"version": "0.1.0"}}
@@ -1049,7 +1056,11 @@ def test_update_version_for_library_success_proto_only_py_project_toml(mocker):
 
     mock_path_exists = mocker.patch("pathlib.Path.exists")
     mock_rglob = mocker.patch("pathlib.Path.rglob")
-    mock_rglob.side_effect = [[], [pathlib.Path("repo/pyproject.toml")]]
+    mock_rglob.side_effect = [
+        [],
+        [pathlib.Path("repo/pyproject.toml")],
+        [pathlib.Path("repo/samples/snippet_metadata.json")]
+    ]
     mock_shutil_copy = mocker.patch("shutil.copy")
     mock_content = 'version = "1.2.2"'
     mock_json_metadata = {"clientLibrary": {"version": "0.1.0"}}