Skip to content

Commit 5164fdb

Browse files
committed
link issues
1 parent 807bc42 commit 5164fdb

File tree

1 file changed

+12
-5
lines changed

1 file changed

+12
-5
lines changed

.generator/cli.py

Lines changed: 12 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -115,6 +115,7 @@ def _write_json_file(path: str, updated_content: Dict):
115115
json.dump(updated_content, f, indent=2)
116116
f.write("\n")
117117

118+
118119
def _add_new_library_source_roots(library_config: Dict, library_id: str) -> None:
119120
"""Adds the default source_roots to the library configuration if not present.
120121
@@ -313,8 +314,9 @@ def _copy_files_needed_for_post_processing(output: str, input: str, library_id:
313314
os.makedirs(
314315
f"{output}/{path_to_library}/scripts/client-post-processing", exist_ok=True
315316
)
316-
# TODO(ohmayr): if `.repo-metadata.json` for a library exists in
317-
# ``.librarian/generator-input`, then we override the generated `.repo-metadata.json`
317+
# TODO(https://github.com/googleapis/librarian/issues/2334):
318+
# if `.repo-metadata.json` for a library exists in
319+
# `.librarian/generator-input`, then we override the generated `.repo-metadata.json`
318320
# with what we have in `generator-input`. Remove this logic once the
319321
# generated `.repo-metadata.json` file is completely backfilled.
320322
if os.path.exists(repo_metadata_path):
@@ -367,6 +369,7 @@ def _clean_up_files_after_post_processing(output: str, library_id: str):
367369
): # pragma: NO COVER
368370
os.remove(gapic_version_file)
369371

372+
370373
def _create_repo_metadata_from_service_config(
371374
service_config_name: str, api_path: str, source: str, library_id: str
372375
) -> Dict:
@@ -383,7 +386,8 @@ def _create_repo_metadata_from_service_config(
383386
"""
384387
full_service_config_path = f"{source}/{api_path}/{service_config_name}"
385388

386-
# TODO(ohmayr): Read the api service config to backfill .repo-metadata.json
389+
# TODO(https://github.com/googleapis/librarian/issues/2332): Read the api
390+
# service config to backfill `.repo-metadata.json`.
387391
return {
388392
"api_shortname": "",
389393
"name_pretty": "",
@@ -416,7 +420,8 @@ def _generate_repo_metadata_file(
416420

417421
os.makedirs(f"{output}/{path_to_library}", exist_ok=True)
418422

419-
# TODO(ohmayr): Programatically determine the primary api to be used to
423+
# TODO(https://github.com/googleapis/librarian/issues/2333): Programatically
424+
# determine the primary api to be used to
420425
# to determine the information for metadata. For now, let's use the first
421426
# api in the list.
422427
primary_api = apis[0]
@@ -1019,7 +1024,9 @@ def _process_changelog(
10191024
entry_parts.append(f"\n\n### {change_type_map[adjusted_change_type]}\n")
10201025
for change in library_changes:
10211026
commit_link = f"([{change[source_commit_hash_key]}]({_REPO_URL}/commit/{change[source_commit_hash_key]}))"
1022-
entry_parts.append(f"* {change[subject_key]} {change[body_key]} {commit_link}")
1027+
entry_parts.append(
1028+
f"* {change[subject_key]} {change[body_key]} {commit_link}"
1029+
)
10231030

10241031
new_entry_text = "\n".join(entry_parts)
10251032
anchor_pattern = re.compile(

0 commit comments

Comments
 (0)