Skip to content

Commit 6508bcd

Browse files
committed
update comments
1 parent 8b8ee02 commit 6508bcd

File tree

1 file changed

+14
-15
lines changed

1 file changed

+14
-15
lines changed

.librarian/generator-input/client-post-processing/bigquery-storage-integration.yaml

Lines changed: 14 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -183,8 +183,8 @@ replacements:
183183
"ReadRowsStream",
184184
"ReadSession",
185185
count: 1
186-
# Given that this file is mostly handwritten, we could omit the file completely when we migrate to librarian
187-
# See `preserve_regex` in https://github.com/googleapis/librarian/blob/main/doc/language-onboarding.md#generate
186+
# Given that this file is mostly handwritten, we could omit the file during code generation
187+
# This will require a change to gapic-generator-python to provide the ability to omit files
188188
- paths: [
189189
packages/google-cloud-bigquery-storage/google/cloud/bigquery_storage_v1/__init__.py,
190190
]
@@ -230,8 +230,8 @@ replacements:
230230
class BigQueryWriteClient(client.BigQueryWriteClient):
231231
__doc__ = client.BigQueryWriteClient.__doc__\n\n
232232
count: 1
233-
# Given that this file is mostly handwritten, we could omit the file completely when we migrate to librarian
234-
# See `preserve_regex` in https://github.com/googleapis/librarian/blob/main/doc/language-onboarding.md#generate
233+
# Given that this file is mostly handwritten, we could omit the file during code generation
234+
# This will require a change to gapic-generator-python to provide the ability to omit files
235235
- paths: [
236236
packages/google-cloud-bigquery-storage/google/cloud/bigquery_storage_v1/__init__.py,
237237
]
@@ -286,8 +286,8 @@ replacements:
286286
"BigQueryWriteClient",
287287
)
288288
count: 1
289-
# Given that this file is mostly handwritten, we could omit the file completely when we migrate to librarian
290-
# See `preserve_regex` in https://github.com/googleapis/librarian/blob/main/doc/language-onboarding.md#generate
289+
# Given that this file is mostly handwritten, we could omit the file during code generation
290+
# This will require a change to gapic-generator-python to provide the ability to omit files
291291
- paths: [
292292
packages/google-cloud-bigquery-storage/google/cloud/bigquery_storage_v1alpha/__init__.py,
293293
packages/google-cloud-bigquery-storage/google/cloud/bigquery_storage_v1beta/__init__.py,
@@ -323,8 +323,8 @@ replacements:
323323
\)\n
324324
after: ""
325325
count: 2
326-
# Given that this file is mostly handwritten, we could omit the file completely when we migrate to librarian
327-
# See `preserve_regex` in https://github.com/googleapis/librarian/blob/main/doc/language-onboarding.md#generate
326+
# Given that this file is mostly handwritten, we could omit the file during code generation
327+
# This will require a change to gapic-generator-python to provide the ability to omit files
328328
- paths: [
329329
packages/google-cloud-bigquery-storage/google/cloud/bigquery_storage_v1alpha/__init__.py,
330330
packages/google-cloud-bigquery-storage/google/cloud/bigquery_storage_v1beta/__init__.py,
@@ -358,8 +358,8 @@ replacements:
358358
after: |
359359
)
360360
count: 2
361-
# Given that this file is mostly handwritten, we could omit the file completely when we migrate to librarian
362-
# See `preserve_regex` in https://github.com/googleapis/librarian/blob/main/doc/language-onboarding.md#generate
361+
# Given that this file is mostly handwritten, we could omit the file during code generation
362+
# This will require a change to gapic-generator-python to provide the ability to omit files
363363
- paths: [
364364
packages/google-cloud-bigquery-storage/google/cloud/bigquery_storage_v1beta2/__init__.py,
365365
]
@@ -398,8 +398,8 @@ replacements:
398398
class BigQueryWriteClient(client.BigQueryWriteClient):
399399
__doc__ = client.BigQueryWriteClient.__doc__\n\n
400400
count: 1
401-
# Given that this file is mostly handwritten, we could omit the file completely when we migrate to librarian
402-
# See `preserve_regex` in https://github.com/googleapis/librarian/blob/main/doc/language-onboarding.md#generate
401+
# Given that this file is mostly handwritten, we could omit the file during code generation
402+
# This will require a change to gapic-generator-python to provide the ability to omit files
403403
- paths: [
404404
packages/google-cloud-bigquery-storage/google/cloud/bigquery_storage_v1beta2/__init__.py,
405405
]
@@ -451,9 +451,6 @@ replacements:
451451
"BigQueryWriteClient",
452452
)
453453
count: 1
454-
# Given that this file is mostly handwritten, we could omit the file completely when we migrate to librarian
455-
# See `preserve_regex` in https://github.com/googleapis/librarian/blob/main/doc/language-onboarding.md#generate
456-
# We could also consider updating the docs/index.rst template so that the majority of handwritten changes are not required
457454
- paths: [
458455
packages/google-cloud-bigquery-storage/testing/constraints-3.7.txt,
459456
]
@@ -468,6 +465,8 @@ replacements:
468465
pyarrow==0.15.0
469466
google-auth==2.14.1
470467
count: 1
468+
# Given that this file is mostly handwritten, we could omit the file during code generation
469+
# This will require a change to gapic-generator-python to provide the ability to omit files
471470
- paths: [
472471
packages/google-cloud-bigquery-storage/docs/index.rst,
473472
]

0 commit comments

Comments
 (0)