Commit 881963d
authored
chore(librarian): fix remove_regex for googleapis-common-protos (#14850)
This PR resolves the following issues when running `librarian generate`
for `googleapis-common-protos`.
- `.repo-metadata.json` is included in the generated output
```
time=2025-11-05T17:00:04.479Z level=ERROR msg="librarian command failed" err="file existed in destination: /usr/local/google/home/partheniou/git/google-cloud-python/packages/googleapis-common-protos/.repo-metadata.json"
```
- `README.rst` is included in the generated output
```
time=2025-11-05T17:03:18.077Z level=ERROR msg="librarian command failed" err="file existed in destination: /usr/local/google/home/partheniou/git/google-cloud-python/packages/googleapis-common-protos/README.rst"
```
- `docs/summary_overview.md` is included in the generated output
```
time=2025-11-05T17:03:56.453Z level=ERROR msg="librarian command failed" err="file existed in destination: /usr/local/google/home/partheniou/git/google-cloud-python/packages/googleapis-common-protos/docs/summary_overview.md"
```
- *.proto files are included in the generated output
```
time=2025-11-05T17:04:30.389Z level=ERROR msg="librarian command failed" err="file existed in destination: /usr/local/google/home/partheniou/git/google-cloud-python/packages/googleapis-common-protos/google/api/annotations.proto"
```
- add `google/logging` which was missed
```
time=2025-11-05T17:07:43.492Z level=ERROR msg="librarian command failed" err="file existed in destination: /usr/local/google/home/partheniou/git/google-cloud-python/packages/googleapis-common-protos/google/logging/type/http_request.proto"
```
This also uncovered an issue where we were not generating code for
https://github.com/googleapis/googleapis/blob/master/google/cloud/common_resources.proto.
I'll address this in a separate PR1 parent bdd15d8 commit 881963d
1 file changed
+4
-1
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
4466 | 4466 | | |
4467 | 4467 | | |
4468 | 4468 | | |
4469 | | - | |
| 4469 | + | |
| 4470 | + | |
| 4471 | + | |
| 4472 | + | |
4470 | 4473 | | |
4471 | 4474 | | |
4472 | 4475 | | |
| |||
0 commit comments