Skip to content

Commit 881963d

Browse files
authored
chore(librarian): fix remove_regex for googleapis-common-protos (#14850)
This PR resolves the following issues when running `librarian generate` for `googleapis-common-protos`. - `.repo-metadata.json` is included in the generated output ``` time=2025-11-05T17:00:04.479Z level=ERROR msg="librarian command failed" err="file existed in destination: /usr/local/google/home/partheniou/git/google-cloud-python/packages/googleapis-common-protos/.repo-metadata.json" ``` - `README.rst` is included in the generated output ``` time=2025-11-05T17:03:18.077Z level=ERROR msg="librarian command failed" err="file existed in destination: /usr/local/google/home/partheniou/git/google-cloud-python/packages/googleapis-common-protos/README.rst" ``` - `docs/summary_overview.md` is included in the generated output ``` time=2025-11-05T17:03:56.453Z level=ERROR msg="librarian command failed" err="file existed in destination: /usr/local/google/home/partheniou/git/google-cloud-python/packages/googleapis-common-protos/docs/summary_overview.md" ``` - *.proto files are included in the generated output ``` time=2025-11-05T17:04:30.389Z level=ERROR msg="librarian command failed" err="file existed in destination: /usr/local/google/home/partheniou/git/google-cloud-python/packages/googleapis-common-protos/google/api/annotations.proto" ``` - add `google/logging` which was missed ``` time=2025-11-05T17:07:43.492Z level=ERROR msg="librarian command failed" err="file existed in destination: /usr/local/google/home/partheniou/git/google-cloud-python/packages/googleapis-common-protos/google/logging/type/http_request.proto" ``` This also uncovered an issue where we were not generating code for https://github.com/googleapis/googleapis/blob/master/google/cloud/common_resources.proto. I'll address this in a separate PR
1 parent bdd15d8 commit 881963d

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

.librarian/state.yaml

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4466,7 +4466,10 @@ libraries:
44664466
- packages/googleapis-common-protos
44674467
preserve_regex: []
44684468
remove_regex:
4469-
- ^packages/googleapis-common-protos/google/(?:api|cloud|rpc|type)/.*/.*_pb2\.(?:py|pyi)$/
4469+
- ^packages/googleapis-common-protos/google/(?:api|cloud|logging|rpc|type)/.*(?:\.proto|_pb2\.(?:py|pyi))$
4470+
- .repo-metadata.json
4471+
- README.rst
4472+
- docs/summary_overview.md
44704473
tag_format: '{id}-v{version}'
44714474
- id: grafeas
44724475
version: 1.16.0

0 commit comments

Comments
 (0)