Skip to content

Commit 95bd440

Browse files
authored
chore(librarian): temporarily switch protobuf backend from upb to python (#15006)
This is a temporary workaround to address #14992 where a crash happens during unit testing of `google-cloud-compute` until we can identify the root cause. This is not trivial to debug since I don't see the problem locally. It only happens in cloud build.
1 parent 45d4cee commit 95bd440

File tree

2 files changed

+6
-3
lines changed

2 files changed

+6
-3
lines changed

.generator/cli.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -996,8 +996,11 @@ def _run_nox_sessions(library_id: str, repo: str, is_mono_repo: bool):
996996
is_mono_repo(bool): True if the current repository is a mono-repo.
997997
"""
998998
session_runtime = "3.14"
999+
# TODO(https://github.com/googleapis/google-cloud-python/issues/14992): Switch the protobuf
1000+
# implementation back to upb once we identify the root cause of the crash that occurs during testing.
1001+
# It's not trivial to debug this since it only happens in cloud build.
9991002
sessions = [
1000-
f"unit-{session_runtime}(protobuf_implementation='upb')",
1003+
f"unit-{session_runtime}(protobuf_implementation='python')",
10011004
]
10021005
current_session = None
10031006
try:

.generator/test_cli.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -794,15 +794,15 @@ def test_run_nox_sessions_success(
794794
mock_run_individual_session = mocker.patch("cli._run_individual_session")
795795

796796
sessions_to_run = [
797-
f"unit-{nox_session_python_runtime}(protobuf_implementation='upb')",
797+
f"unit-{nox_session_python_runtime}(protobuf_implementation='python')",
798798
]
799799
_run_nox_sessions("mock-library", "repo", is_mono_repo)
800800

801801
assert mock_run_individual_session.call_count == len(sessions_to_run)
802802
mock_run_individual_session.assert_has_calls(
803803
[
804804
mocker.call(
805-
f"unit-{nox_session_python_runtime}(protobuf_implementation='upb')",
805+
f"unit-{nox_session_python_runtime}(protobuf_implementation='python')",
806806
"mock-library",
807807
"repo",
808808
is_mono_repo,

0 commit comments

Comments
 (0)