Skip to content

Commit daa8c45

Browse files
authored
chore(librarian): rename source_commit_hash to commit_hash (#14737)
See googleapis/librarian#2224
1 parent 018b740 commit daa8c45

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

.generator/cli.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1207,7 +1207,7 @@ def _process_changelog(
12071207

12081208
# Group changes by type (e.g., feat, fix, docs)
12091209
type_key = "type"
1210-
source_commit_hash_key = "source_commit_hash"
1210+
commit_hash_key = "commit_hash"
12111211
subject_key = "subject"
12121212
body_key = "body"
12131213
library_changes.sort(key=lambda x: x[type_key])
@@ -1224,7 +1224,7 @@ def _process_changelog(
12241224
if adjusted_change_type in change_type_map:
12251225
entry_parts.append(f"\n\n### {change_type_map[adjusted_change_type]}\n")
12261226
for change in library_changes:
1227-
commit_link = f"([{change[source_commit_hash_key]}]({_REPO_URL}/commit/{change[source_commit_hash_key]}))"
1227+
commit_link = f"([{change[commit_hash_key]}]({_REPO_URL}/commit/{change[commit_hash_key]}))"
12281228
entry_parts.append(
12291229
f"* {change[subject_key]} {change[body_key]} {commit_link}"
12301230
)

.generator/test_cli.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -83,28 +83,28 @@
8383
"subject": "add new UpdateRepository API",
8484
"body": "This adds the ability to update a repository's properties.",
8585
"piper_cl_number": "786353207",
86-
"source_commit_hash": "9461532e7d19c8d71709ec3b502e5d81340fb661",
86+
"commit_hash": "9461532e7d19c8d71709ec3b502e5d81340fb661",
8787
},
8888
{
8989
"type": "fix",
9090
"subject": "some fix",
9191
"body": "some body",
9292
"piper_cl_number": "786353208",
93-
"source_commit_hash": "1231532e7d19c8d71709ec3b502e5d81340fb661",
93+
"commit_hash": "1231532e7d19c8d71709ec3b502e5d81340fb661",
9494
},
9595
{
9696
"type": "fix",
9797
"subject": "another fix",
9898
"body": "",
9999
"piper_cl_number": "786353209",
100-
"source_commit_hash": "1241532e7d19c8d71709ec3b502e5d81340fb661",
100+
"commit_hash": "1241532e7d19c8d71709ec3b502e5d81340fb661",
101101
},
102102
{
103103
"type": "docs",
104104
"subject": "fix typo in BranchRule comment",
105105
"body": "",
106106
"piper_cl_number": "786353210",
107-
"source_commit_hash": "9461532e7d19c8d71709ec3b502e5d81340fb661",
107+
"commit_hash": "9461532e7d19c8d71709ec3b502e5d81340fb661",
108108
},
109109
]
110110

0 commit comments

Comments
 (0)