Skip to content

Commit dff9e32

Browse files
authored
chore(librarian): update exception and valid namespaces (#14458)
This fixes the following issue which caused #14457 to fail with `Generation failed for google-cloud-video-live-stream` ``` ValueError: Build failed. raise ValueError("Build failed.") from e File "/app/./cli.py", line 601, in handle_build args.func(librarian=args.librarian, repo=args.repo) File "/app/./cli.py", line 1014, in <module> Traceback (most recent call last): The above exception was the direct cause of the following exception: ValueError: The namespace `google.cloud.video` for `google-cloud-video-live-stream` must be one of ['google', 'google.apps', 'google.ads', 'google.cloud', 'google.maps', 'google.shopping', 'google.cloud.billing']. raise ValueError( File "/app/./cli.py", line 546, in _verify_library_namespace _verify_library_namespace(library_id, repo) File "/app/./cli.py", line 597, in handle_build Traceback (most recent call last): ```
1 parent d0b9c9f commit dff9e32

File tree

1 file changed

+19
-1
lines changed

1 file changed

+19
-1
lines changed

.generator/cli.py

Lines changed: 19 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -508,14 +508,32 @@ def _verify_library_namespace(library_id: str, repo: str):
508508
repo (str): The path to the root of the repository.
509509
"""
510510
# TODO(https://github.com/googleapis/google-cloud-python/issues/14376): Update the list of namespaces which are exceptions.
511-
exception_namespaces = ["google.cloud.billing"]
511+
exception_namespaces = [
512+
"google.area120",
513+
"google.apps.script",
514+
"google.apps.script.type",
515+
"google.cloud.alloydb",
516+
"google.cloud.billing",
517+
"google.cloud.devtools",
518+
"google.cloud.gkeconnect",
519+
"google.cloud.gkehub_v1",
520+
"google.cloud.orchestration.airflow",
521+
"google.cloud.security",
522+
"google.cloud.video",
523+
"google.cloud.workflows",
524+
"google.monitoring",
525+
]
512526
valid_namespaces = [
513527
"google",
528+
"google.analytics",
514529
"google.apps",
515530
"google.ads",
531+
"google.ai",
516532
"google.cloud",
533+
"google.geo",
517534
"google.maps",
518535
"google.shopping",
536+
"grafeas",
519537
*exception_namespaces,
520538
]
521539
gapic_version_file = "gapic_version.py"

0 commit comments

Comments
 (0)