Skip to content

Commit ea55384

Browse files
feat: [google-cloud-gke-hub] add k8s_git_version field (#14421)
BEGIN_COMMIT_OVERRIDE feat: add k8s_git_version field docs: correct comment for k8s_version field The new field k8s_git_version captures the full Kubernetes version string for a membership. END_COMMIT_OVERRIDE - [ ] Regenerate this pull request now. docs: correct comment for `k8s_version` field The new field `k8s_git_version` captures the full Kubernetes version string for a membership. PiperOrigin-RevId: 805935629 Source-Link: googleapis/googleapis@780e612 Source-Link: googleapis/googleapis-gen@d0c6d1d Copy-Tag: eyJwIjoicGFja2FnZXMvZ29vZ2xlLWNsb3VkLWdrZS1odWIvLk93bEJvdC55YW1sIiwiaCI6ImQwYzZkMWRmNGY0NjAyNWVjMDE2MGE0YWNmZTI0ZThlYWYzNjFkYWIifQ== --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
1 parent 2d33a6b commit ea55384

File tree

4 files changed

+26
-4
lines changed

4 files changed

+26
-4
lines changed

packages/google-cloud-gke-hub/google/cloud/gkehub_v1/types/membership.py

Lines changed: 11 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -315,10 +315,15 @@ class ResourceOptions(proto.Message):
315315
This option should be set for clusters with Kubernetes
316316
apiserver versions <1.16.
317317
k8s_version (str):
318-
Optional. Major version of the Kubernetes cluster. This is
319-
only used to determine which version to use for the
318+
Optional. Major and minor version of the Kubernetes cluster.
319+
This is only used to determine which version to use for the
320320
CustomResourceDefinition resources,
321321
``apiextensions/v1beta1`` or\ ``apiextensions/v1``.
322+
k8s_git_version (str):
323+
Optional. Git version of the Kubernetes
324+
cluster. This is only used to gate the Connect
325+
Agent migration to svc.id.goog on GDC-SO
326+
1.33.100 patch and above.
322327
"""
323328

324329
connect_version: str = proto.Field(
@@ -333,6 +338,10 @@ class ResourceOptions(proto.Message):
333338
proto.STRING,
334339
number=3,
335340
)
341+
k8s_git_version: str = proto.Field(
342+
proto.STRING,
343+
number=4,
344+
)
336345

337346

338347
class ResourceManifest(proto.Message):

packages/google-cloud-gke-hub/google/cloud/gkehub_v1beta1/types/membership.py

Lines changed: 11 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -418,10 +418,15 @@ class ResourceOptions(proto.Message):
418418
This option should be set for clusters with Kubernetes
419419
apiserver versions <1.16.
420420
k8s_version (str):
421-
Optional. Major version of the Kubernetes cluster. This is
422-
only used to determine which version to use for the
421+
Optional. Major and minor version of the Kubernetes cluster.
422+
This is only used to determine which version to use for the
423423
CustomResourceDefinition resources,
424424
``apiextensions/v1beta1`` or\ ``apiextensions/v1``.
425+
k8s_git_version (str):
426+
Optional. Git version of the Kubernetes
427+
cluster. This is only used to gate the Connect
428+
Agent migration to svc.id.goog on GDC-SO
429+
1.33.100 patch and above.
425430
"""
426431

427432
connect_version: str = proto.Field(
@@ -436,6 +441,10 @@ class ResourceOptions(proto.Message):
436441
proto.STRING,
437442
number=3,
438443
)
444+
k8s_git_version: str = proto.Field(
445+
proto.STRING,
446+
number=4,
447+
)
439448

440449

441450
class ResourceManifest(proto.Message):

packages/google-cloud-gke-hub/tests/unit/gapic/gkehub_v1/test_gke_hub.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8178,6 +8178,7 @@ def test_create_membership_rest_call_success(request_type):
81788178
"connect_version": "connect_version_value",
81798179
"v1beta1_crd": True,
81808180
"k8s_version": "k8s_version_value",
8181+
"k8s_git_version": "k8s_git_version_value",
81818182
},
81828183
},
81838184
"google_managed": True,
@@ -8860,6 +8861,7 @@ def test_update_membership_rest_call_success(request_type):
88608861
"connect_version": "connect_version_value",
88618862
"v1beta1_crd": True,
88628863
"k8s_version": "k8s_version_value",
8864+
"k8s_git_version": "k8s_git_version_value",
88638865
},
88648866
},
88658867
"google_managed": True,

packages/google-cloud-gke-hub/tests/unit/gapic/gkehub_v1beta1/test_gke_hub_membership_service.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6303,6 +6303,7 @@ def test_create_membership_rest_call_success(request_type):
63036303
"connect_version": "connect_version_value",
63046304
"v1beta1_crd": True,
63056305
"k8s_version": "k8s_version_value",
6306+
"k8s_git_version": "k8s_git_version_value",
63066307
},
63076308
},
63086309
},
@@ -6682,6 +6683,7 @@ def test_update_membership_rest_call_success(request_type):
66826683
"connect_version": "connect_version_value",
66836684
"v1beta1_crd": True,
66846685
"k8s_version": "k8s_version_value",
6686+
"k8s_git_version": "k8s_git_version_value",
66856687
},
66866688
},
66876689
},

0 commit comments

Comments
 (0)