Skip to content

Switch to rustls #3811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Switch to rustls #3811

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b43bd68
feat(deps): add rustls support to reqwest for musl compatibility
casibbald Nov 14, 2025
601d718
feat(deps): use tls-webpki-roots instead of tls-native-roots for musl…
casibbald Nov 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -314,7 +314,7 @@ prost = { default-features = false, version = "0.14", features =
prost-build = { default-features = false, version = "0.14" }
prost-types = { default-features = false, version = "0.14" }
rand = { default-features = false, version = "0.9.2" }
reqwest = { default-features = false, version = "0.12.24", features = ["json"] }
Copy link
Collaborator

@coryan coryan Nov 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm... my understanding is that you can enable these features in your own Cargo.toml file, and if we enable them here no downstream dependency could disable them. Is that not the case?

reqwest = { default-features = false, version = "0.12.24", features = ["json", "rustls-tls", "rustls-tls-webpki-roots"] }
rustls = { default-features = false, version = "0.23" }
rustls-pemfile = { default-features = false, version = "2" }
serde = { default-features = false, version = "1.0.228", features = ["serde_derive"] }
Expand All @@ -325,7 +325,7 @@ thiserror = { default-features = false, version = "2" }
time = { default-features = false, version = "0.3.44" }
tokio = { default-features = false, version = "1" }
tokio-metrics = { default-features = false, version = "0.4.5" }
tonic = { default-features = false, version = "0.14.1", features = ["tls-native-roots", "tls-ring"] }
Copy link
Collaborator

@coryan coryan Nov 14, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could be a problem. But we should fix it by reducing the number of default features.

tonic = { default-features = false, version = "0.14.1", features = ["tls-ring", "tls-webpki-roots"] }
tonic-prost = { default-features = false, version = "0.14.2" }
tonic-prost-build = { default-features = false, version = "0.14.1" }
tower = { default-features = false, version = "0.5", features = ["util"] }
Expand Down
Loading