-
Notifications
You must be signed in to change notification settings - Fork 94
docs(auth): add builder examples to id token builder #3818
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(auth): add builder examples to id token builder #3818
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3818 +/- ##
=======================================
Coverage 96.18% 96.18%
=======================================
Files 149 149
Lines 5767 5767
=======================================
Hits 5547 5547
Misses 220 220 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
coryan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding a lot of details in the example and then hiding the details does not make sense to me. We should do one or the other.
@coryan good points, I moved the full example with the credential format in the Builder example. The Builder methods have a shorter version of it, with just |
Splitting work on #3762 that can already be merged.