Skip to content

Conversation

@alvarowolfx
Copy link
Collaborator

Splitting work on #3762 that can already be merged.

@alvarowolfx alvarowolfx requested review from a team as code owners November 17, 2025 14:52
@codecov
Copy link

codecov bot commented Nov 17, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.18%. Comparing base (18663f6) to head (9956af3).
⚠️ Report is 8 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3818   +/-   ##
=======================================
  Coverage   96.18%   96.18%           
=======================================
  Files         149      149           
  Lines        5767     5767           
=======================================
  Hits         5547     5547           
  Misses        220      220           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@coryan coryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding a lot of details in the example and then hiding the details does not make sense to me. We should do one or the other.

@alvarowolfx alvarowolfx changed the title docs(auth): add builder examples to id token buidler docs(auth): add builder examples to id token builder Nov 17, 2025
@alvarowolfx
Copy link
Collaborator Author

Adding a lot of details in the example and then hiding the details does not make sense to me. We should do one or the other.

@coryan good points, I moved the full example with the credential format in the Builder example. The Builder methods have a shorter version of it, with just add details here. This is more in line with the docs on the other Credentials. Also fixed the MDS thing (I thought that this was going to be captured by docs being build 🤔 )

@alvarowolfx alvarowolfx requested a review from coryan November 17, 2025 16:11
@alvarowolfx alvarowolfx merged commit 42e64c8 into googleapis:main Nov 17, 2025
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants