-
Notifications
You must be signed in to change notification settings - Fork 49
Open
Labels
api: storageIssues related to the googleapis/google-resumable-media-python API.Issues related to the googleapis/google-resumable-media-python API.type: feature request‘Nice-to-have’ improvement, new feature or different behavior or design.‘Nice-to-have’ improvement, new feature or different behavior or design.
Description
Hi,
In get_next_chunk() method the stream is concluded to have ended on the read data being less than chunk_size rather than a empty chunk.
if total_bytes is None:
if num_bytes_read < chunk_size:
# We now **KNOW** the total number of bytes.
total_bytes = end_byte + 1
This could be a cause of concern especially in case of dynamically generated data (where nothing is written to file and data is being directly uploaded to GCS)
akuzminsky, danmilon and Edorka
Metadata
Metadata
Assignees
Labels
api: storageIssues related to the googleapis/google-resumable-media-python API.Issues related to the googleapis/google-resumable-media-python API.type: feature request‘Nice-to-have’ improvement, new feature or different behavior or design.‘Nice-to-have’ improvement, new feature or different behavior or design.