Skip to content

Commit 1b3da5b

Browse files
committed
chore: address gemini review comments
1 parent e51c8be commit 1b3da5b

File tree

1 file changed

+7
-14
lines changed

1 file changed

+7
-14
lines changed

google-cloud-bigquery-jdbc/README.MD

Lines changed: 7 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -20,20 +20,20 @@ If you are using Maven, add this to your pom.xml file:
2020
<dependency>
2121
<groupId>com.google.cloud</groupId>
2222
<artifactId>google-cloud-bigquery-jdbc</artifactId>
23-
<version>0.1.0</version>
23+
<version>0.1.0-SNAPSHOT</version>
2424
</dependency>
2525
```
2626

2727
If you are using Gradle without BOM, add this to your dependencies:
2828

2929
```Groovy
30-
implementation 'com.google.cloud:google-cloud-bigquery-jdbc:0.1.0'
30+
implementation 'com.google.cloud:google-cloud-bigquery-jdbc:0.1.0-SNAPSHOT'
3131
```
3232

3333
If you are using SBT, add this to your dependencies:
3434

3535
```Scala
36-
libraryDependencies += "com.google.cloud" % "google-cloud-bigquery-jdbc" % "0.1.0"
36+
libraryDependencies += "com.google.cloud" % "google-cloud-bigquery-jdbc" % "0.1.0-SNAPSHOT"
3737
```
3838
<!-- {x-version-update-end} -->
3939

@@ -94,7 +94,7 @@ Run all integration tests (currently takes 15+ minutes, so this is discouraged).
9494

9595
`make integration-test`
9696

97-
Run specific unitintegration test
97+
Run specific integration test
9898

9999
`make integration-test test=<filter>`
100100

@@ -114,7 +114,7 @@ make docker-unittest
114114
make docker-integration-test
115115
```
116116

117-
Please note that running unit of integration tests within docker doesn't leverage maven cache because it is not persisted.
117+
Please note that running unit or integration tests within docker doesn't leverage maven cache because it is not persisted.
118118
If you want to run multiple commands, you can start a session and treat this shell session as your local environment.
119119

120120
```
@@ -156,7 +156,7 @@ make run QUERY=small
156156

157157
Nightly build is running full set of Integration tests and extended Nightly tests that includes some long-running tests (takes 20+ minutes to complete).
158158

159-
Nightly Integration Tests include a step to build a full and thin jars and upload them to [Google Storage](https://pantheon.corp.google.com/storage/browser/bq_devtools_release_private/drivers/jdbc;tab=objects?inv=1&invt=Ab4E6g&project=bigquery-devtools-drivers&prefix=&forceOnObjectsSortingFiltering=false).
159+
Nightly Integration Tests include a step to build a full and thin jars and upload them to Google Storage.
160160

161161
They can be retrieved via following commands:
162162

@@ -167,8 +167,7 @@ gsutil cp gs://bq_devtools_release_private/drivers/jdbc/google-cloud-bigquery-jd
167167

168168
#### Performance tests
169169

170-
[Cloud Build Pipeline](https://pantheon.corp.google.com/cloud-build/triggers;region=us-east1/edit/125214da-8603-449d-8336-b6dba7196bb4?project=bigquery-devtools-drivers)
171-
is uploading latest full jar to the internal location for perf tests once a week, at the moment scheduled to do this Sunday night.
170+
Cloud Build Pipeline is uploading latest full jar to the internal location for perf tests once a week, at the moment scheduled to do this Sunday night.
172171

173172
### Code Coverage
174173

@@ -288,8 +287,6 @@ Java is a registered trademark of Oracle and/or its affiliates.
288287

289288
[product-docs]: https://cloud.google.com/bigquery
290289
[javadocs]: https://cloud.google.com/java/docs/reference/google-cloud-bigquery/latest/history
291-
[kokoro-badge-image-1]: http://storage.googleapis.com/cloud-devrel-public/java/badges/java-bigquery-jdbc/java7.svg
292-
[kokoro-badge-link-1]: http://storage.googleapis.com/cloud-devrel-public/java/badges/java-bigquery-jdbc/java7.html
293290
[kokoro-badge-image-2]: http://storage.googleapis.com/cloud-devrel-public/java/badges/java-bigquery-jdbc/java8.svg
294291
[kokoro-badge-link-2]: http://storage.googleapis.com/cloud-devrel-public/java/badges/java-bigquery-jdbc/java8.html
295292
[kokoro-badge-image-3]: http://storage.googleapis.com/cloud-devrel-public/java/badges/java-bigquery-jdbc/java8-osx.svg
@@ -313,10 +310,6 @@ Java is a registered trademark of Oracle and/or its affiliates.
313310
[code-of-conduct]: https://github.com/googleapis/java-bigquery/blob/main/CODE_OF_CONDUCT.md
314311
[license]: https://github.com/googleapis/java-bigquery/blob/main/LICENSE
315312

316-
317-
[libraries-bom]: https://github.com/GoogleCloudPlatform/cloud-opensource-java/wiki/The-Google-Cloud-Platform-Libraries-BOM
318-
[shell_img]: https://gstatic.com/cloudssh/images/open-btn.png
319-
320313
[semver]: https://semver.org/
321314
[cloudlibs]: https://cloud.google.com/apis/docs/client-libraries-explained
322315
[apilibs]: https://cloud.google.com/apis/docs/client-libraries-explained#google_api_client_libraries

0 commit comments

Comments
 (0)