Skip to content

Commit 71a4513

Browse files
committed
chore: Address code comments
1 parent b840e7c commit 71a4513

File tree

7 files changed

+11
-8
lines changed

7 files changed

+11
-8
lines changed

samples/snippets/src/main/java/com/example/bigquerystorage/ExportOpenTelemetry.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -175,7 +175,7 @@ private JsonStreamWriter createStreamWriter(String tableName)
175175
// For more information about JsonStreamWriter, see:
176176
// https://googleapis.dev/java/google-cloud-bigquerystorage/latest/com/google/cloud/bigquery/storage/v1/JsonStreamWriter.html
177177
return JsonStreamWriter.newBuilder(tableName, client)
178-
.setExecutorProvider(FixedExecutorProvider.create(Executors.newScheduledThreadPool(100)))
178+
.setExecutorProvider(FixedExecutorProvider.create(Executors.newScheduledThreadPool(10)))
179179
.setChannelProvider(
180180
BigQueryWriteSettings.defaultGrpcTransportProviderBuilder()
181181
.setKeepAliveTime(org.threeten.bp.Duration.ofMinutes(1))

samples/snippets/src/main/java/com/example/bigquerystorage/ReadTimestampArrow.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -118,7 +118,7 @@ public static void main(String... args) throws Exception {
118118
try (BigQueryReadClient client = BigQueryReadClient.create()) {
119119
String parent = String.format("projects/%s", projectId);
120120

121-
// This example uses baby name data from the public datasets.
121+
// This example uses citibike data from the public datasets.
122122
String srcTable =
123123
String.format(
124124
"projects/%s/datasets/%s/tables/%s",

samples/snippets/src/main/java/com/example/bigquerystorage/ReadTimestampAvro.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,7 @@ public static void main(String... args) throws Exception {
8585
try (BigQueryReadClient client = BigQueryReadClient.create()) {
8686
String parent = String.format("projects/%s", projectId);
8787

88-
// This example uses baby name data from the public datasets.
88+
// This example uses citibike data from the public datasets.
8989
String srcTable =
9090
String.format(
9191
"projects/%s/datasets/%s/tables/%s",

samples/snippets/src/main/java/com/example/bigquerystorage/WriteToDefaultStream.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -176,7 +176,7 @@ private JsonStreamWriter createStreamWriter(String tableName)
176176
// For more information about JsonStreamWriter, see:
177177
// https://googleapis.dev/java/google-cloud-bigquerystorage/latest/com/google/cloud/bigquery/storage/v1/JsonStreamWriter.html
178178
return JsonStreamWriter.newBuilder(tableName, client)
179-
.setExecutorProvider(FixedExecutorProvider.create(Executors.newScheduledThreadPool(100)))
179+
.setExecutorProvider(FixedExecutorProvider.create(Executors.newScheduledThreadPool(10)))
180180
.setChannelProvider(
181181
BigQueryWriteSettings.defaultGrpcTransportProviderBuilder()
182182
.setKeepAliveTime(org.threeten.bp.Duration.ofMinutes(1))

samples/snippets/src/main/java/com/example/bigquerystorage/WriteToDefaultStreamTimestampJson.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -157,7 +157,7 @@ private JsonStreamWriter createStreamWriter(String tableName)
157157
// For more information about JsonStreamWriter, see:
158158
// https://googleapis.dev/java/google-cloud-bigquerystorage/latest/com/google/cloud/bigquery/storage/v1/JsonStreamWriter.html
159159
return JsonStreamWriter.newBuilder(tableName, client)
160-
.setExecutorProvider(FixedExecutorProvider.create(Executors.newScheduledThreadPool(100)))
160+
.setExecutorProvider(FixedExecutorProvider.create(Executors.newScheduledThreadPool(10)))
161161
.setChannelProvider(
162162
BigQueryWriteSettings.defaultGrpcTransportProviderBuilder()
163163
.setKeepAliveTime(org.threeten.bp.Duration.ofMinutes(1))

samples/snippets/src/main/java/com/example/bigquerystorage/WriteToDefaultStreamTimestampWithArrow.java

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -71,6 +71,8 @@
7171
*/
7272
public class WriteToDefaultStreamTimestampWithArrow {
7373

74+
public static final long NANOS = 1000000000L;
75+
7476
public static void main(String[] args) throws InterruptedException, IOException {
7577
if (args.length < 3) {
7678
System.out.println(
@@ -100,8 +102,9 @@ private static ArrowRecordBatch buildRecordBatch(VectorSchemaRoot root, int rowC
100102
TimeStampNanoTZVector timestampField = (TimeStampNanoTZVector) root.getVector("timestampField");
101103
timestampField.allocateNew(rowCount);
102104

105+
Instant now = Instant.now();
103106
for (int i = 0; i < rowCount; i++) {
104-
timestampField.set(i, Instant.now().getNano());
107+
timestampField.set(i, now.getEpochSecond() * NANOS + now.getNano());
105108
}
106109
root.setRowCount(rowCount);
107110

@@ -228,7 +231,7 @@ private StreamWriter createStreamWriter(String streamName, Schema arrowSchema)
228231
// For more information about StreamWriter, see:
229232
// https://cloud.google.com/java/docs/reference/google-cloud-bigquerystorage/latest/com.google.cloud.bigquery.storage.v1.StreamWriter
230233
return StreamWriter.newBuilder(streamName, client)
231-
.setExecutorProvider(FixedExecutorProvider.create(Executors.newScheduledThreadPool(100)))
234+
.setExecutorProvider(FixedExecutorProvider.create(Executors.newScheduledThreadPool(10)))
232235
.setChannelProvider(
233236
BigQueryWriteSettings.defaultGrpcTransportProviderBuilder()
234237
.setKeepAliveTime(org.threeten.bp.Duration.ofMinutes(1))

samples/snippets/src/main/java/com/example/bigquerystorage/WriteToDefaultStreamWithArrow.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -236,7 +236,7 @@ private StreamWriter createStreamWriter(String streamName, Schema arrowSchema)
236236
// For more information about StreamWriter, see:
237237
// https://cloud.google.com/java/docs/reference/google-cloud-bigquerystorage/latest/com.google.cloud.bigquery.storage.v1.StreamWriter
238238
return StreamWriter.newBuilder(streamName, client)
239-
.setExecutorProvider(FixedExecutorProvider.create(Executors.newScheduledThreadPool(100)))
239+
.setExecutorProvider(FixedExecutorProvider.create(Executors.newScheduledThreadPool(10)))
240240
.setChannelProvider(
241241
BigQueryWriteSettings.defaultGrpcTransportProviderBuilder()
242242
.setKeepAliveTime(org.threeten.bp.Duration.ofMinutes(1))

0 commit comments

Comments
 (0)