From 87ad7edd2b8bfe0fdf814ff2761661e4fc4eb6fd Mon Sep 17 00:00:00 2001 From: Tomo Suzuki Date: Tue, 26 Aug 2025 10:31:46 -0400 Subject: [PATCH 1/2] ci: fix the pom.xml for Central API New Maven Central API has more strict pom.xml validation than the old Maven publication. Let's fix the problem: ``` { "pkg:maven/com.google.cloud.bigtable/bigtable-hbase-1.x-shaded@2.15.3": [ "Project name is missing", "Dependency management dependency version information is missing for dependency: org.conscrypt:conscrypt-openjdk-uber", "Dependency management dependency version information is missing for dependency: org.conscrypt:conscrypt-openjdk", "Dependency management dependency version information is missing for dependency: javax.annotation:javax.annotation-api", "Dependency management dependency version information is missing for dependency: org.checkerframework:checker-qual", "Dependency management dependency version information is missing for dependency: com.google.code.findbugs:jsr305" ], "pkg:maven/com.google.cloud.bigtable/bigtable-hbase-1.x-hadoop@2.15.3": [ "Project name is missing" ], "pkg:maven/com.google.cloud.bigtable/bigtable-hbase-2.x-shaded@2.15.3": [ "Project name is missing", "Dependency management dependency version information is missing for dependency: org.conscrypt:conscrypt-openjdk-uber", "Dependency management dependency version information is missing for dependency: org.conscrypt:conscrypt-openjdk", "Dependency management dependency version information is missing for dependency: javax.annotation:javax.annotation-api", "Dependency management dependency version information is missing for dependency: org.checkerframework:checker-qual", "Dependency management dependency version information is missing for dependency: com.google.code.findbugs:jsr305" ], "pkg:maven/com.google.cloud.bigtable/bigtable-beam-import@2.15.3": [ "Project name is missing" ], "pkg:maven/com.google.cloud.bigtable/bigtable-hbase-2.x-hadoop@2.15.3": [ "Project name is missing" ], "pkg:maven/com.google.cloud.bigtable/protobuf-java-format-shaded@0.10.3": [ "Project name is missing" ], "pkg:maven/com.google.cloud.bigtable/mirroring-client@0.10.3": [ "Project name is missing" ] } ``` --- .../bigtable-beam-import/pom.xml | 1 + .../bigtable-hbase-1.x-hadoop/pom.xml | 1 + .../bigtable-hbase-1.x-shaded/pom.xml | 39 ++++--------------- .../bigtable-hbase-2.x-hadoop/pom.xml | 1 + .../bigtable-hbase-2.x-shaded/pom.xml | 39 ++++--------------- .../protobuf-java-format-shaded/pom.xml | 1 + .../mirroring-client/pom.xml | 1 + 7 files changed, 21 insertions(+), 62 deletions(-) diff --git a/bigtable-dataflow-parent/bigtable-beam-import/pom.xml b/bigtable-dataflow-parent/bigtable-beam-import/pom.xml index dec2d21a4b..d2762b432d 100644 --- a/bigtable-dataflow-parent/bigtable-beam-import/pom.xml +++ b/bigtable-dataflow-parent/bigtable-beam-import/pom.xml @@ -23,6 +23,7 @@ limitations under the License. 4.0.0 bigtable-beam-import + ${project.groupId}:${project.artifactId} com.google.cloud.bigtable.beam.Main diff --git a/bigtable-hbase-1.x-parent/bigtable-hbase-1.x-hadoop/pom.xml b/bigtable-hbase-1.x-parent/bigtable-hbase-1.x-hadoop/pom.xml index b29a446bf2..0879ece230 100644 --- a/bigtable-hbase-1.x-parent/bigtable-hbase-1.x-hadoop/pom.xml +++ b/bigtable-hbase-1.x-parent/bigtable-hbase-1.x-hadoop/pom.xml @@ -23,6 +23,7 @@ limitations under the License. 4.0.0 bigtable-hbase-1.x-hadoop + ${project.groupId}:${project.artifactId} Bigtable connector compatible with HBase 1.x. It most of its dependencies (hbase & grpc). Its mainly intended to be used by dataflow 1.x to avoid diff --git a/bigtable-hbase-1.x-parent/bigtable-hbase-1.x-shaded/pom.xml b/bigtable-hbase-1.x-parent/bigtable-hbase-1.x-shaded/pom.xml index 1ea321c1e4..1740f0baf1 100644 --- a/bigtable-hbase-1.x-parent/bigtable-hbase-1.x-shaded/pom.xml +++ b/bigtable-hbase-1.x-parent/bigtable-hbase-1.x-shaded/pom.xml @@ -23,6 +23,7 @@ limitations under the License. 4.0.0 bigtable-hbase-1.x-shaded + ${project.groupId}:${project.artifactId} Please use bigtable-hbase-1.x or bigtable-hbase-1.x-hadoop. Bigtable connector compatible with HBase 1.x. It exposes the minimal set of @@ -48,37 +49,6 @@ limitations under the License. pom import - - - - org.conscrypt - conscrypt-openjdk-uber - provided - - - org.conscrypt - conscrypt-openjdk - provided - - - - - javax.annotation - javax.annotation-api - provided - - - org.checkerframework - checker-qual - provided - - - com.google.code.findbugs - jsr305 - provided - @@ -254,6 +224,13 @@ limitations under the License. org.slf4j:slf4j-log4j12 ch.qos.reload4j:reload4j + + org.conscrypt:conscrypt-openjdk-uber + org.conscrypt:conscrypt-openjdk + + javax.annotation:javax.annotation-api + org.checkerframework:checker-qual + com.google.code.findbugs:jsr305 diff --git a/bigtable-hbase-2.x-parent/bigtable-hbase-2.x-hadoop/pom.xml b/bigtable-hbase-2.x-parent/bigtable-hbase-2.x-hadoop/pom.xml index 0564917da0..1e2ef60169 100644 --- a/bigtable-hbase-2.x-parent/bigtable-hbase-2.x-hadoop/pom.xml +++ b/bigtable-hbase-2.x-parent/bigtable-hbase-2.x-hadoop/pom.xml @@ -21,6 +21,7 @@ limitations under the License. 2.15.3 4.0.0 + ${project.groupId}:${project.artifactId} bigtable-hbase-2.x-hadoop diff --git a/bigtable-hbase-2.x-parent/bigtable-hbase-2.x-shaded/pom.xml b/bigtable-hbase-2.x-parent/bigtable-hbase-2.x-shaded/pom.xml index b870b937c6..940f39fc4e 100644 --- a/bigtable-hbase-2.x-parent/bigtable-hbase-2.x-shaded/pom.xml +++ b/bigtable-hbase-2.x-parent/bigtable-hbase-2.x-shaded/pom.xml @@ -23,6 +23,7 @@ limitations under the License. 4.0.0 bigtable-hbase-2.x-shaded + ${project.groupId}:${project.artifactId} Please use bigtable-hbase-2.x or bigtable-hbase-2.x-hadoop. Bigtable connector compatible with HBase 2.x. It exposes the minimal set of @@ -48,37 +49,6 @@ limitations under the License. pom import - - - - org.conscrypt - conscrypt-openjdk-uber - provided - - - org.conscrypt - conscrypt-openjdk - provided - - - - - javax.annotation - javax.annotation-api - provided - - - org.checkerframework - checker-qual - provided - - - com.google.code.findbugs - jsr305 - provided - @@ -241,6 +211,13 @@ limitations under the License. org.apache.htrace:htrace-core4 commons-logging:commons-logging org.apache.yetus:audience-annotations + + org.conscrypt:conscrypt-openjdk-uber + org.conscrypt:conscrypt-openjdk + + javax.annotation:javax.annotation-api + org.checkerframework:checker-qual + com.google.code.findbugs:jsr305 diff --git a/hbase-migration-tools/mirroring-client/bigtable-hbase-mirroring-client-core-parent/protobuf-java-format-shaded/pom.xml b/hbase-migration-tools/mirroring-client/bigtable-hbase-mirroring-client-core-parent/protobuf-java-format-shaded/pom.xml index adec071277..ea23f0c640 100644 --- a/hbase-migration-tools/mirroring-client/bigtable-hbase-mirroring-client-core-parent/protobuf-java-format-shaded/pom.xml +++ b/hbase-migration-tools/mirroring-client/bigtable-hbase-mirroring-client-core-parent/protobuf-java-format-shaded/pom.xml @@ -9,6 +9,7 @@ protobuf-java-format-shaded + ${project.groupId}:${project.artifactId} 0.10.3 diff --git a/hbase-migration-tools/mirroring-client/pom.xml b/hbase-migration-tools/mirroring-client/pom.xml index 44520411b6..0c490c5d7f 100644 --- a/hbase-migration-tools/mirroring-client/pom.xml +++ b/hbase-migration-tools/mirroring-client/pom.xml @@ -9,6 +9,7 @@ mirroring-client + ${project.groupId}:${project.artifactId} pom 0.10.3 From 8035712e247e101473af79d6195944255393f3ab Mon Sep 17 00:00:00 2001 From: Tomo Suzuki Date: Tue, 26 Aug 2025 10:52:03 -0400 Subject: [PATCH 2/2] Revert shade config --- .../bigtable-hbase-1.x-shaded/pom.xml | 38 +++++++++++++++---- .../bigtable-hbase-2.x-shaded/pom.xml | 38 +++++++++++++++---- 2 files changed, 62 insertions(+), 14 deletions(-) diff --git a/bigtable-hbase-1.x-parent/bigtable-hbase-1.x-shaded/pom.xml b/bigtable-hbase-1.x-parent/bigtable-hbase-1.x-shaded/pom.xml index 1740f0baf1..5a751b47a8 100644 --- a/bigtable-hbase-1.x-parent/bigtable-hbase-1.x-shaded/pom.xml +++ b/bigtable-hbase-1.x-parent/bigtable-hbase-1.x-shaded/pom.xml @@ -49,6 +49,37 @@ limitations under the License. pom import + + + + org.conscrypt + conscrypt-openjdk-uber + provided + + + org.conscrypt + conscrypt-openjdk + provided + + + + + javax.annotation + javax.annotation-api + provided + + + org.checkerframework + checker-qual + provided + + + com.google.code.findbugs + jsr305 + provided + @@ -224,13 +255,6 @@ limitations under the License. org.slf4j:slf4j-log4j12 ch.qos.reload4j:reload4j - - org.conscrypt:conscrypt-openjdk-uber - org.conscrypt:conscrypt-openjdk - - javax.annotation:javax.annotation-api - org.checkerframework:checker-qual - com.google.code.findbugs:jsr305 diff --git a/bigtable-hbase-2.x-parent/bigtable-hbase-2.x-shaded/pom.xml b/bigtable-hbase-2.x-parent/bigtable-hbase-2.x-shaded/pom.xml index 940f39fc4e..f71b96fd24 100644 --- a/bigtable-hbase-2.x-parent/bigtable-hbase-2.x-shaded/pom.xml +++ b/bigtable-hbase-2.x-parent/bigtable-hbase-2.x-shaded/pom.xml @@ -49,6 +49,37 @@ limitations under the License. pom import + + + + org.conscrypt + conscrypt-openjdk-uber + provided + + + org.conscrypt + conscrypt-openjdk + provided + + + + + javax.annotation + javax.annotation-api + provided + + + org.checkerframework + checker-qual + provided + + + com.google.code.findbugs + jsr305 + provided + @@ -211,13 +242,6 @@ limitations under the License. org.apache.htrace:htrace-core4 commons-logging:commons-logging org.apache.yetus:audience-annotations - - org.conscrypt:conscrypt-openjdk-uber - org.conscrypt:conscrypt-openjdk - - javax.annotation:javax.annotation-api - org.checkerframework:checker-qual - com.google.code.findbugs:jsr305