Skip to content

Commit 4da61d6

Browse files
feat: large-row-skip | IT are running now (#2525)
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly: - [ ] Make sure to open an issue as a [bug/issue](https://togithub.com/googleapis/java-bigtable/issues/new/choose) before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea - [ ] Ensure the tests and linter pass - [ ] Code coverage does not decrease (if any source code was changed) - [ ] Appropriate docs were updated (if necessary) - [ ] Rollback plan is reviewed and LGTMed - [ ] All new data plane features have a completed end to end testing plan Fixes #<issue_number_goes_here> ☕️ If you write sample code, please follow the [samples format]( https://togithub.com/GoogleCloudPlatform/java-docs-samples/blob/main/SAMPLE_FORMAT.md).
1 parent 4b821bf commit 4da61d6

File tree

1 file changed

+8
-6
lines changed
  • google-cloud-bigtable/src/test/java/com/google/cloud/bigtable/data/v2/it

1 file changed

+8
-6
lines changed

google-cloud-bigtable/src/test/java/com/google/cloud/bigtable/data/v2/it/LargeRowIT.java

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@
3333
import com.google.cloud.bigtable.data.v2.models.RowMutation;
3434
import com.google.cloud.bigtable.data.v2.models.RowMutationEntry;
3535
import com.google.cloud.bigtable.data.v2.models.TableId;
36-
import com.google.cloud.bigtable.test_helpers.env.CloudEnv;
36+
import com.google.cloud.bigtable.test_helpers.env.EmulatorEnv;
3737
import com.google.cloud.bigtable.test_helpers.env.PrefixGenerator;
3838
import com.google.cloud.bigtable.test_helpers.env.TestEnvRule;
3939
import com.google.common.collect.ImmutableList;
@@ -48,7 +48,6 @@
4848
import org.junit.After;
4949
import org.junit.Before;
5050
import org.junit.ClassRule;
51-
import org.junit.Ignore;
5251
import org.junit.Test;
5352
import org.junit.runner.RunWith;
5453
import org.junit.runners.JUnit4;
@@ -147,15 +146,18 @@ public void onComplete() {
147146
}
148147
}
149148

150-
// TODO: remove the ignore annotation once the server code (large row error with metadata) is
151-
// released on prod
152149
@Test
153-
@Ignore("large-row-error with metadata yet to be released on prod")
154150
public void read() throws Throwable {
155151
assume()
156152
.withMessage("Large row read errors are not supported by emulator")
157153
.that(testEnvRule.env())
158-
.isInstanceOf(CloudEnv.class);
154+
.isNotInstanceOf(EmulatorEnv.class);
155+
156+
// TODO: remove this once skip large row for read is released
157+
assume()
158+
.withMessage("Skip large row for read is not released yet")
159+
.that(System.getProperty("bigtable.testSkipLargeRowIntegrationTests"))
160+
.isEqualTo("true");
159161

160162
BigtableDataClient client = testEnvRule.env().getDataClient();
161163
String tableId = table.getId();

0 commit comments

Comments
 (0)