Skip to content

Commit 6e6dd0a

Browse files
chore: export internal DirectAccess gRPC metrics to the new bigtable_client monitored resource (#2547)
This will export a relevant subset of the metrics described in https://togithub.com/grpc/proposal/blob/master/A78-grpc-metrics-wrr-pf-xds.md as internal metrics to help rollout of DirectAccess Change-Id: Ifddadb84d091f0f904f8f0f6e8da52de552e9757 Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly: - [ ] Make sure to open an issue as a [bug/issue](https://togithub.com/googleapis/java-bigtable/issues/new/choose) before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea - [ ] Ensure the tests and linter pass - [ ] Code coverage does not decrease (if any source code was changed) - [ ] Appropriate docs were updated (if necessary) - [ ] Rollback plan is reviewed and LGTMed - [ ] All new data plane features have a completed end to end testing plan Fixes #<issue_number_goes_here> ☕️ If you write sample code, please follow the [samples format]( https://togithub.com/GoogleCloudPlatform/java-docs-samples/blob/main/SAMPLE_FORMAT.md).
1 parent 0cc3997 commit 6e6dd0a

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/stub/metrics/BuiltinMetricsConstants.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -64,6 +64,7 @@ public class BuiltinMetricsConstants {
6464
static final String CLIENT_BLOCKING_LATENCIES_NAME = "throttling_latencies";
6565
static final String PER_CONNECTION_ERROR_COUNT_NAME = "per_connection_error_count";
6666

67+
// Start allow list of metrics that will be exported as internal
6768
public static final Map<String, Set<String>> GRPC_METRICS =
6869
ImmutableMap.<String, Set<String>>builder()
6970
.put(
@@ -95,6 +96,7 @@ public class BuiltinMetricsConstants {
9596
ImmutableSet.of(PER_CONNECTION_ERROR_COUNT_NAME).stream()
9697
.map(m -> METER_NAME + m)
9798
.collect(ImmutableSet.toImmutableSet());
99+
// End allow list of metrics that will be exported
98100

99101
// Buckets under 100,000 are identical to buckets for server side metrics handler_latencies.
100102
// Extending client side bucket to up to 3,200,000.

0 commit comments

Comments
 (0)