Skip to content

Commit 7d5108e

Browse files
authored
chore: use BaseApiTracer and BaseApiTracerFactory (#879)
Extends `BaseApiTracer` and `BaseApiTracerFactory` instead of implementing `ApiTracer` and `ApiTracerFactory` after gax change is picked up. New methods could be added to `ApiTracer` and won't break the client. Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly: - [ ] Make sure to open an issue as a [bug/issue](https://github.com/googleapis/java-bigtable/issues/new/choose) before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea - [ ] Ensure the tests and linter pass - [ ] Code coverage does not decrease (if any source code was changed) - [ ] Appropriate docs were updated (if necessary) Fixes #<issue_number_goes_here> ☕️
1 parent 95e5379 commit 7d5108e

File tree

4 files changed

+8
-5
lines changed

4 files changed

+8
-5
lines changed

google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/stub/metrics/CompositeTracer.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,13 +16,14 @@
1616
package com.google.cloud.bigtable.data.v2.stub.metrics;
1717

1818
import com.google.api.gax.tracing.ApiTracer;
19+
import com.google.api.gax.tracing.BaseApiTracer;
1920
import com.google.common.collect.ImmutableList;
2021
import java.util.ArrayList;
2122
import java.util.List;
2223
import org.threeten.bp.Duration;
2324

2425
/** Combines multiple {@link ApiTracer}s into a single {@link ApiTracer}. */
25-
class CompositeTracer implements ApiTracer {
26+
class CompositeTracer extends BaseApiTracer {
2627
private final List<ApiTracer> children;
2728

2829
CompositeTracer(List<ApiTracer> children) {

google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/stub/metrics/CompositeTracerFactory.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,14 +18,15 @@
1818
import com.google.api.core.InternalApi;
1919
import com.google.api.gax.tracing.ApiTracer;
2020
import com.google.api.gax.tracing.ApiTracerFactory;
21+
import com.google.api.gax.tracing.BaseApiTracerFactory;
2122
import com.google.api.gax.tracing.SpanName;
2223
import com.google.common.collect.ImmutableList;
2324
import java.util.ArrayList;
2425
import java.util.List;
2526

2627
/** Combines multiple {@link ApiTracerFactory} into a single {@link ApiTracerFactory}. */
2728
@InternalApi("For internal use only")
28-
public class CompositeTracerFactory implements ApiTracerFactory {
29+
public class CompositeTracerFactory extends BaseApiTracerFactory {
2930
private final List<ApiTracerFactory> apiTracerFactories;
3031

3132
public CompositeTracerFactory(List<ApiTracerFactory> apiTracerFactories) {

google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/stub/metrics/MetricsTracer.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,8 @@
1515
*/
1616
package com.google.cloud.bigtable.data.v2.stub.metrics;
1717

18-
import com.google.api.gax.tracing.ApiTracer;
1918
import com.google.api.gax.tracing.ApiTracerFactory.OperationType;
19+
import com.google.api.gax.tracing.BaseApiTracer;
2020
import com.google.api.gax.tracing.SpanName;
2121
import com.google.common.base.Stopwatch;
2222
import io.opencensus.stats.MeasureMap;
@@ -34,7 +34,7 @@
3434
import javax.annotation.Nullable;
3535
import org.threeten.bp.Duration;
3636

37-
class MetricsTracer implements ApiTracer {
37+
class MetricsTracer extends BaseApiTracer {
3838

3939
private final OperationType operationType;
4040

google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/stub/metrics/MetricsTracerFactory.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@
1818
import com.google.api.core.InternalApi;
1919
import com.google.api.gax.tracing.ApiTracer;
2020
import com.google.api.gax.tracing.ApiTracerFactory;
21+
import com.google.api.gax.tracing.BaseApiTracerFactory;
2122
import com.google.api.gax.tracing.SpanName;
2223
import com.google.common.collect.ImmutableMap;
2324
import io.opencensus.stats.StatsRecorder;
@@ -30,7 +31,7 @@
3031
* api.
3132
*/
3233
@InternalApi("For internal use only")
33-
public class MetricsTracerFactory implements ApiTracerFactory {
34+
public class MetricsTracerFactory extends BaseApiTracerFactory {
3435
private final Tagger tagger;
3536
private final StatsRecorder stats;
3637
private final ImmutableMap<TagKey, TagValue> statsAttributes;

0 commit comments

Comments
 (0)