Skip to content

Commit c3e9230

Browse files
chore(test): remove some warnings from tests (#2398)
Make sure to close the ephemeral stubs to avoid polluting the logs with unclosed channel errors
1 parent 81431d9 commit c3e9230

File tree

1 file changed

+17
-14
lines changed

1 file changed

+17
-14
lines changed

google-cloud-bigtable/src/test/java/com/google/cloud/bigtable/data/v2/stub/sql/ExecuteQueryCallableTest.java

Lines changed: 17 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -124,15 +124,16 @@ public void testExecuteQueryRequestsIgnoreOverriddenMaxAttempts() throws IOExcep
124124
.stubSettings()
125125
.executeQuerySettings()
126126
.setRetrySettings(RetrySettings.newBuilder().setMaxAttempts(10).build());
127-
EnhancedBigtableStub overrideStub =
128-
EnhancedBigtableStub.create(overrideSettings.build().getStubSettings());
129-
SqlServerStream stream =
130-
overrideStub.executeQueryCallable().call(Statement.of("SELECT * FROM table"));
131127

132-
Iterator<SqlRow> iterator = stream.rows().iterator();
128+
try (EnhancedBigtableStub overrideStub =
129+
EnhancedBigtableStub.create(overrideSettings.build().getStubSettings())) {
130+
SqlServerStream stream =
131+
overrideStub.executeQueryCallable().call(Statement.of("SELECT * FROM table"));
132+
Iterator<SqlRow> iterator = stream.rows().iterator();
133133

134-
assertThrows(UnavailableException.class, iterator::next).getCause();
135-
assertThat(fakeService.attempts).isEqualTo(1);
134+
assertThrows(UnavailableException.class, iterator::next).getCause();
135+
assertThat(fakeService.attempts).isEqualTo(1);
136+
}
136137
}
137138

138139
@Test
@@ -160,13 +161,15 @@ public void testExecuteQueryRequestsRespectDeadline() throws IOException {
160161
.setInitialRpcTimeout(Duration.ofMillis(10))
161162
.setMaxRpcTimeout(Duration.ofMillis(10))
162163
.build());
163-
EnhancedBigtableStub overrideDeadline =
164-
EnhancedBigtableStub.create(overrideSettings.build().getStubSettings());
165-
SqlServerStream streamOverride =
166-
overrideDeadline.executeQueryCallable().call(Statement.of("SELECT * FROM table"));
167-
Iterator<SqlRow> overrideIterator = streamOverride.rows().iterator();
168-
// We don't care about this but are reusing the fake service that tests retries
169-
assertThrows(DeadlineExceededException.class, overrideIterator::next).getCause();
164+
165+
try (EnhancedBigtableStub overrideDeadline =
166+
EnhancedBigtableStub.create(overrideSettings.build().getStubSettings())) {
167+
SqlServerStream streamOverride =
168+
overrideDeadline.executeQueryCallable().call(Statement.of("SELECT * FROM table"));
169+
Iterator<SqlRow> overrideIterator = streamOverride.rows().iterator();
170+
// We don't care about this but are reusing the fake service that tests retries
171+
assertThrows(DeadlineExceededException.class, overrideIterator::next).getCause();
172+
}
170173
}
171174

172175
private static class FakeService extends BigtableGrpc.BigtableImplBase {

0 commit comments

Comments
 (0)