Skip to content

Commit d8055c1

Browse files
authored
feat(bigtable): lower the value for max rpc channels as channel resize is slow (1m, 2 channel) (#2656)
…conservative Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly: - [ ] Make sure to open an issue as a [bug/issue](https://togithub.com/googleapis/java-bigtable/issues/new/choose) before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea - [ ] Ensure the tests and linter pass - [ ] Code coverage does not decrease (if any source code was changed) - [ ] Appropriate docs were updated (if necessary) - [ ] Rollback plan is reviewed and LGTMed - [ ] All new data plane features have a completed end to end testing plan Fixes #<issue_number_goes_here> ☕️ If you write sample code, please follow the [samples format]( https://togithub.com/GoogleCloudPlatform/java-docs-samples/blob/main/SAMPLE_FORMAT.md).
1 parent e652e0f commit d8055c1

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/stub/EnhancedBigtableStubSettings.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -446,7 +446,9 @@ public static InstantiatingGrpcChannelProvider.Builder defaultGrpcTransportProvi
446446
ChannelPoolSettings.builder()
447447
.setInitialChannelCount(10)
448448
.setMinRpcsPerChannel(1)
449-
.setMaxRpcsPerChannel(50)
449+
// Keep it conservative as we scale the channel size every 1min
450+
// and delta is 2 channels.
451+
.setMaxRpcsPerChannel(25)
450452
.setPreemptiveRefreshEnabled(true)
451453
.build())
452454
.setMaxInboundMessageSize(MAX_MESSAGE_SIZE)

0 commit comments

Comments
 (0)