Skip to content

Commit 6ee5f00

Browse files
committed
fix sample assertions
1 parent a9e0fbf commit 6ee5f00

File tree

2 files changed

+11
-7
lines changed

2 files changed

+11
-7
lines changed

samples/snippets/src/main/java/com/example/datastore/filters/MultiIneqFilter.java

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,8 @@
2929
import com.google.cloud.datastore.QueryResults;
3030
import com.google.cloud.datastore.StructuredQuery.CompositeFilter;
3131
import com.google.cloud.datastore.StructuredQuery.PropertyFilter;
32+
import java.util.ArrayList;
33+
import java.util.List;
3234

3335
public class MultiIneqFilter {
3436
public static void invoke() throws Exception {
@@ -51,9 +53,11 @@ public static void invoke() throws Exception {
5153
throw new Exception("query yielded no results");
5254
}
5355

56+
List<Entity> entities = new ArrayList<>();
5457
while (results.hasNext()) {
55-
Entity entity = results.next();
56-
System.out.printf("Entity: %s%n", entity);
58+
entities.add(results.next());
5759
}
60+
61+
return entities;
5862
}
5963
}

samples/snippets/src/test/java/com/example/datastore/filters/MultiIneqFilterSampleIT.java

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,8 @@
3030
import org.junit.Test;
3131
import org.junit.runner.RunWith;
3232
import org.junit.runners.JUnit4;
33-
33+
import java.util.ArrayList;
34+
import java.util.List;
3435

3536
@RunWith(JUnit4.class)
3637
@SuppressWarnings("checkstyle:abbreviationaswordinname")
@@ -86,10 +87,9 @@ public void tearDown() {
8687

8788
@Test
8889
public void testMultiIneqFilter() throws Exception {
89-
// Act
90-
MultiIneqFilter.invoke();
90+
List<Entity> results = MultiIneqFilter.invoke();
9191

92-
// Assert
93-
systemsOutRule.assertContains("Entity");
92+
assertEquals(3, results.size());
93+
assertEquals("Learn Cloud Datastore", results.get(0).getString("description"));
9494
}
9595
}

0 commit comments

Comments
 (0)