Skip to content

Commit f082807

Browse files
committed
Resolve conflicts
1 parent 3e31255 commit f082807

File tree

2 files changed

+8
-6
lines changed

2 files changed

+8
-6
lines changed

.kokoro/build.sh

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -60,16 +60,16 @@ javadoc)
6060
RETURN_CODE=$?
6161
;;
6262
integration)
63-
# Kokoro integration test uses both JDK 11 and JDK 8. Integration
64-
# tests require JDK 11 to compile the classes.
63+
# Kokoro integration tests use both JDK 11 and JDK 8. Integration
64+
# tests require JDK 11 export as JAVA env variable to run cloud datastore
65+
# emulator (https://cloud.google.com/sdk/docs/release-notes#39300_2022-07-12).
66+
# For Java 8 environment, we will still run the tests using Java 8 with
67+
# SUREFIRE_JVM_OPT for Maven surefire plugin:
68+
# https://maven.apache.org/surefire/maven-surefire-plugin/test-mojo.html#jvm
6569
if [[ -n "${JAVA11_HOME}" && -n "${JAVA8_HOME}" ]]
6670
then
6771
export JAVA=${JAVA11_HOME}/bin/java
6872
export SUREFIRE_JVM_OPT=-Djvm=${JAVA8_HOME}/bin/java
69-
echo "Java:${JAVA}"
70-
echo "Java 11:${JAVA11_HOME}"
71-
echo "Java 8:${JAVA8_HOME}"
72-
echo "SUREFIRE_JVM_OPT: ${SUREFIRE_JVM_OPT}"
7373
fi
7474

7575
mvn -B ${INTEGRATION_TEST_ARGS} \

google-cloud-datastore/src/main/java/com/google/cloud/datastore/testing/LocalDatastoreHelper.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -188,6 +188,8 @@ private LocalDatastoreHelper(Builder builder) {
188188
List<String> binCommand = new ArrayList<>(Arrays.asList(binName, "start"));
189189
binCommand.add("--testing");
190190
if (builder.firestoreInDatastoreMode) {
191+
// Downloadable emulator runner takes the flag in a different
192+
// format: --firestore_in_datastore_mode
191193
binCommand.add("--firestore_in_datastore_mode");
192194
} else {
193195
// At most one of --consistency | --firestore_in_datastore_mode can be specified.

0 commit comments

Comments
 (0)