Tweaks

Author: wu-hui

google-cloud-firestore/src/main/java/com/google/cloud/firestore/pipeline/expressions/Constant.java

@@ -2,6 +2,7 @@
 
 import static com.google.cloud.firestore.PipelineUtils.encodeValue;
 
+import com.google.api.core.InternalApi;
 import com.google.cloud.Timestamp;
 import com.google.cloud.firestore.Blob;
 import com.google.cloud.firestore.DocumentReference;
@@ -51,10 +52,12 @@ public static Constant of(DocumentReference value) {
     return new Constant(value);
   }
 
+  @InternalApi
   public static Constant of(Value value) {
     return new Constant(value);
   }
 
+  @InternalApi
   static Constant of(Object value) {
     if (value == null) {
       return new Constant(null);
@@ -83,15 +86,15 @@ static Constant of(Object value) {
     }
   }
 
-  public static <T> Constant ofArray(Iterable<T> value) {
+  public static <T> Constant of(Iterable<T> value) {
     return new Constant(value);
   }
 
-  public static <T> Constant ofArray(T[] value) {
+  public static <T> Constant of(T[] value) {
     return new Constant(Arrays.asList(value)); // Convert array to list
   }
 
-  public static <T> Constant ofMap(Map<String, T> value) {
+  public static <T> Constant of(Map<String, T> value) {
     return new Constant(value);
   }
 

google-cloud-firestore/src/main/java/com/google/cloud/firestore/pipeline/expressions/Function.java

@@ -317,7 +317,7 @@ public static EuclideanDistance euclideanDistance(String field, double[] other)
     return new EuclideanDistance(Field.of(field), Constant.ofVector(other));
   }
 
-  public static Generic function(String name, List<Expr> params) {
-    return new Generic(name, params);
+  public static Function function(String name, List<Expr> params) {
+    return new Function(name, params);
   }
 }