Setup CI against enterprise

Author: wu-hui

.kokoro/presubmit/graalvm-c.cfg

@@ -13,7 +13,7 @@ env_vars: {
 
 env_vars: {
   key: "INTEGRATION_TEST_ARGS"
-  value: "-DFIRESTORE_EDITION=standard"
+  value: "-DFIRESTORE_NAMED_DATABASE=enterprise -DFIRESTORE_EDITION=enterprise"
 }
 
 # TODO: remove this after we've migrated all tests and scripts

.kokoro/presubmit/graalvm-native-c.cfg

@@ -13,7 +13,7 @@ env_vars: {
 
 env_vars: {
   key: "INTEGRATION_TEST_ARGS"
-  value: "-DFIRESTORE_EDITION=standard"
+  value: "-DFIRESTORE_NAMED_DATABASE=enterprise -DFIRESTORE_EDITION=enterprise"
 }
 
 env_vars: {

.kokoro/presubmit/integration-named-db.cfg

@@ -13,7 +13,7 @@ env_vars: {
 
 env_vars: {
   key: "INTEGRATION_TEST_ARGS"
-  value: "-DFIRESTORE_NAMED_DATABASE=test-db -DFIRESTORE_EDITION=standard"
+  value: "-DFIRESTORE_NAMED_DATABASE=enterprise -DFIRESTORE_EDITION=enterprise"
 }
 
 env_vars: {

google-cloud-firestore/src/main/java/com/google/cloud/firestore/AggregateQuery.java

@@ -91,20 +91,20 @@ public Query getQuery() {
   Pipeline pipeline() {
     Pipeline pipeline = getQuery().pipeline();
 
-    List<BooleanExpression> existsExprs =
-        this.aggregateFieldList.stream()
-            .map(PipelineUtils::toPipelineExistsExpr)
-            .filter(Objects::nonNull)
-            .collect(Collectors.toList());
-    if (existsExprs.size() == 1) {
-      pipeline = pipeline.where(existsExprs.get(0));
-    } else if (existsExprs.size() > 1) {
-      pipeline =
-          pipeline.where(
-              and(
-                  existsExprs.get(0),
-                  existsExprs.subList(1, existsExprs.size()).toArray(new BooleanExpression[0])));
-    }
+    // List<BooleanExpression> existsExprs =
+    //     this.aggregateFieldList.stream()
+    //         .map(PipelineUtils::toPipelineExistsExpr)
+    //         .filter(Objects::nonNull)
+    //         .collect(Collectors.toList());
+    // if (existsExprs.size() == 1) {
+    //   pipeline = pipeline.where(existsExprs.get(0));
+    // } else if (existsExprs.size() > 1) {
+    //   pipeline =
+    //       pipeline.where(
+    //           and(
+    //               existsExprs.get(0),
+    //               existsExprs.subList(1, existsExprs.size()).toArray(new BooleanExpression[0])));
+    // }
 
     return pipeline.aggregate(
         this.aggregateFieldList.stream()

google-cloud-firestore/src/test/java/com/google/cloud/firestore/it/ITPipelineTest.java

@@ -1161,15 +1161,20 @@ public void testLogicalAndComparisonOperators() throws Exception {
             .pipeline()
             .createFrom(collection)
             .where(
-                Expression.notEqualAny("genre", Lists.newArrayList("Romance", "Dystopian", null)))
+                Expression.notEqualAny(
+                    "genre", Lists.newArrayList("Science Fiction", "Romance", "Dystopian", null)))
             .select("genre")
             .distinct("genre")
             .execute()
             .get()
             .getResults();
     assertThat(data(results))
         .containsExactly(
-            map("genre", "Science Fiction"),
+            // This is somewhat surprising because the pipeline did ask specifically for genre not
+            // equal to null,
+            // however at the later distinct stage, UNSET is grouped as null and thus null appears
+            // in the result.
+            map("genre", null),
             map("genre", "Magical Realism"),
             map("genre", "Fantasy"),
             map("genre", "Psychological Thriller"),
@@ -1236,10 +1241,9 @@ public void testChecks() throws Exception {
             .select(
                 field("rating").equal(nullValue()).as("ratingIsNull"),
                 field("rating").equal(Double.NaN).as("ratingIsNaN"),
+                // arrayGet("title", 0) evaluates to UNSET
                 arrayGet("title", 0).isError().as("isError"),
-                arrayGet("title", 0)
-                    .ifError(constant("was error"), constant("was not error"))
-                    .as("ifError"),
+                arrayGet("title", 0).ifError(constant("was error")).as("ifError"),
                 field("foo").isAbsent().as("isAbsent"),
                 field("title").notEqual(nullValue()).as("titleIsNotNull"),
                 field("cost").notEqual(Double.NaN).as("costIsNotNan"),
@@ -1259,8 +1263,6 @@ public void testChecks() throws Exception {
                     false,
                     "isError",
                     false,
-                    "ifError",
-                    "was not error",
                     "isAbsent",
                     true,
                     "titleIsNotNull",