feat: Add support for new Firestore types #2097
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: type definition for six types. * formatting and add some encoding logic. * Add class mapper and data converter logic. * Add Int32Value class. * Add ordering logic. * Add unit tests for encoding, decoding, and ordering. * Add roundtrip (write and read back) integration tests. * More integration tests with filter and ordering. * fix: use a valid Bson ObjectId. * Address feedback 1. * Address feedback 2. * Address feedback 3. * Fix the parameter ordering for BsonBinaryData.
product-auto-label
bot
added
size: xl
* feat: Add `Decimal128Value` support. * Address feedback. * Address feedback, and fix serialization. * Address feedback. * Add test for numerically equal numbers of different types. * Format. * Address feedback. * Format. * Update the Quadruple and QuadrupleBuilder with the latest updates from GOB. * Fix the documentation lint CI failure.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for MinKey, MaxKey, RegexValue, Int32Value, Decimal128Value, BsonObjectId, BsonTimestamp, and BsonBinaryData.